FuriHal, drivers: rework gauge initialization routine #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over from any kind of internal/external issue
skotopes
requested review from
DrZlo13,
hedger,
gsurkov and
nminaylov
as code owners
|
Compiled f7 firmware for commit |
|
PVS-Studio report for commit |
skotopes
changed the title
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
hedger
reviewed
Oct 2, 2024
…essing. Fixes all known issues.
…dictable result and minimum amount of interaction with gauge, add documentation and notes.
hedger
reviewed
Oct 6, 2024
hedger
previously approved these changes
Oct 6, 2024
hedger
reviewed
Oct 6, 2024
hedger
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! Warning !!!
This PR changes gauge security settings: by default gauge will be SEALED, we only unseal it for a short period of time while doing initialization routine.
This was done to prevent configuration damage and gauge transition into state where recovery becomes complex.
Downgrade from this firmware is not possible, it will break old initialization routine, you will see
[ - ]instead of battery indicator.If you must downgrade then use https://github.com/skotopes/flipperzero_gauge_tool to unseal gauge.
What's new
Verification
[ - ]modeChecklist (For Reviewer)