Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furi_hal_rtc: new function #3294

Merged
merged 12 commits into from
Jan 14, 2024
Merged

Furi_hal_rtc: new function #3294

merged 12 commits into from
Jan 14, 2024

Conversation

Leptopt1los
Copy link
Contributor

@Leptopt1los Leptopt1los commented Dec 14, 2023 •
edited by skotopes
Loading

What's new

  • furi_hal_rtc_timestamp_to_datetime function added

Verification

  • build the firmware
  • test the correctness of furi_hal_rtc_timestamp_to_datetime (the result furi_hal_rtc_timestamp_to_datetime (furi_hal_rtc_datetime_to_timestamp(X)) must be equals to X)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added New Feature Contains an IMPLEMENTATION of a new feature Core+Services HAL, furi & core system services labels Dec 17, 2023
@skotopes
Copy link
Member

@Leptopt1los can you also add unit tests?

@Leptopt1los
Copy link
Contributor Author

@Leptopt1los can you also add unit tests?

done. sorry for the delay

@Leptopt1los
Copy link
Contributor Author

@skotopes are there any problems with this pull request? Is anything else required on my part?

@skotopes
Copy link
Member

nope, I'll try to merge it in this RC cycle

@gornekich gornekich mentioned this pull request Jan 10, 2024
Merged
3 tasks
@skotopes skotopes merged commit 3fd5f15 into flipperdevices:dev Jan 14, 2024
9 checks passed
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Feb 13, 2024
@Leptopt1los @hedger
@skotopes @xMasterX
Furi_hal_rtc: new function (flipperdevices#3294)
1fd4839 
* furi_hal_rtc_timestamp_to_datetime added
* hw targets api version sync
* hw targets api version sync, bump
* FuriHal: update rtc docs
* unit tests added

Co-authored-by: hedger <[email protected]>
Co-authored-by: Aleksandr Kutuzov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leptopt1los @skotopes @hedger