Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3699] HID: Add confirmation dialogue to the remove pairing option #3263

Merged
merged 9 commits into from
Feb 17, 2024
Merged

[FL-3699] HID: Add confirmation dialogue to the remove pairing option #3263

merged 9 commits into from
Feb 17, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Dec 4, 2023 •
edited by skotopes
Loading

What's new

  • "Remove pairing" behaviour in HID app matches the behaviour in Bluetooth settings now

Verification

  • Check that pairing gets removed
  • Check that the UI flow is as expected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Compiled f7 firmware for commit 0a620a6b:

@hryamzik hryamzik mentioned this pull request Dec 5, 2023
Closed
3 tasks
@hedger hedger added UI Affects UI Applications Non-core applications labels Dec 12, 2023
@skotopes skotopes marked this pull request as draft December 12, 2023 15:17
@Astrrra Astrrra marked this pull request as ready for review December 21, 2023 00:14
@github-actions GitHub Actions
Copy link

PVS-Studio report for commit 540d6da7:

@Astrrra Astrrra requested a review from gornekich as a code owner January 14, 2024 06:38
@skotopes skotopes marked this pull request as draft January 14, 2024 06:59
@skotopes skotopes marked this pull request as ready for review February 17, 2024 08:14
@skotopes skotopes requested a review from gsurkov as a code owner February 17, 2024 08:14
@skotopes skotopes merged commit 2c650b5 into dev Feb 17, 2024
9 checks passed
@skotopes skotopes deleted the astra/3699-hid-remove-pairing-dialogue branch February 17, 2024 08:15
tpimh pushed a commit to tpimh/flipper-jackbox-remote that referenced this pull request Mar 5, 2024
@Astrrra @skotopes
[FL-3699] HID: Add confirmation dialogue to the remove pairing option (…
833e794 
…flipperdevices#3263)

* HID: Add confirmation dialogue to the un-pair option
* Initial refactor to use SceneManager
* Make PVS happy
* Fix the exit dialog

Co-authored-by: あく <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
Applications Non-core applications UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger