Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPATIBLE_WRITE command fix #3135

Merged
merged 43 commits into from
Oct 9, 2023
Merged

COMPATIBLE_WRITE command fix #3135

merged 43 commits into from
Oct 9, 2023

Conversation

RebornedBrain
Copy link
Contributor

@RebornedBrain RebornedBrain commented Oct 6, 2023 •
edited
Loading

What's new

  • [ Describe changes here ]

Verification

COMPATIBILITY WRITE (NTAG213):

hf 14a raw -sck A001 - comp write to block 1
<< NAK (00)

hf 14a raw -sck A02D - comp write to block 2D (out of range)
<< NAK (00)

hf 14a raw -sck A00A - comp write to block 10
<< ACK
hf 14a raw -ac DEADBEAF00112233445566778899AABB - data
<< ACK

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

RebornedBrain and others added 30 commits August 31, 2023 14:46
@RebornedBrain
Added callback on FieldOff event from 14443 to mfu
832084f
@RebornedBrain
Moved command enum and callback type to _i.h file
0a059ce
@RebornedBrain
Added context for composite command to mfu_listener
a1646cf
@RebornedBrain
Functions for composite commands processing added
9739b23
@RebornedBrain
Composite commands processing logic added
3ffda5d
@RebornedBrain
Added COMP_WRITE command implementation
e9ca28a
@RebornedBrain
Patch with some fixes
27d6b02
@RebornedBrain
Merge branch 'gornek/nfc_refactoring'
3ad0f14
@RebornedBrain
Merge branch 'gornek/nfc_refactoring'
c416a82
@RebornedBrain
New mfu command result added for composite commands
6b21e6c
@RebornedBrain
Added variable for storing sector for SECTOR_SELECT cmd
a4566a9
@RebornedBrain
Implemented proper way of reset for composite cmds
6b8f935
@RebornedBrain
SECTOR_SELECT implementation added
317bd3a
@RebornedBrain
Merge commit '2ad34a725717193dd8f0f5acf2a129d53a2b496f'
6531546
@RebornedBrain
Adjust naming for PR
31243c2
@RebornedBrain
Update api_symbols.csv, nfc.h, and mf_ultralight_listener.c
fd349f9
@RebornedBrain
Merge branch 'gornek/nfc_refactoring'
a081f96
@RebornedBrain
FAST_READ cmd define added
aadc629
@RebornedBrain
Added functions for PWD and PACK pages processing
a31d95e
@RebornedBrain
Tx buffer size increased to maximum nfc package
8666710
@RebornedBrain
Added functions for i2c page validation and allocation
82c0fb3
@RebornedBrain
READ and FAST_READ commands implementation and adjustments
c2b8b96 
Both cmds now work through one function
NtagI2C support added
@RebornedBrain
Update api_symbols.csv
fa13faf
@RebornedBrain
Renamed i2c bool switch and fixed FAST_READ where it was hardcoded
8888380
@RebornedBrain
Replaced some parts of code by defines
7128dfc
@RebornedBrain
Merge branch 'gornek/nfc_refactoring'
05bd6cc 
Conflicts:
	firmware/targets/f7/api_symbols.csv
@RebornedBrain
VCSL cmd added for Ultralights
2476dc8
@RebornedBrain
Implementation of VCSL cmd added
2dc870c
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
7cd4801 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
9f67885 
…fc_refactoring_v1
RebornedBrain and others added 13 commits September 13, 2023 15:43
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
ed84285 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
9f79717 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
15dcde0 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
8eaafd9 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
7688376 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
16a6a44 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
8358021 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
e8e6911 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
d331d44 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
7e4a25f 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
696e97b 
…fc_refactoring_v1
@RebornedBrain
Merge branch 'flipperdevices:gornek/nfc_refactoring_v1' into gornek/n…
02d59a7 
…fc_refactoring_v1
@RebornedBrain
Fixed last page border for compatible write command
47cee2b
@gornekich gornekich merged commit 9883120 into flipperdevices:gornek/nfc_refactoring_v1 Oct 9, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gornekich gornekich gornekich approved these changes

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13

@hedger hedger Awaiting requested review from hedger

@Astrrra Astrrra Awaiting requested review from Astrrra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RebornedBrain @gornekich