Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to iOS 14 #147

Closed
wants to merge 37 commits into from

Conversation

ilyamodder
Copy link

@ilyamodder ilyamodder commented Oct 14, 2022

I think hacker device's companion app should be compatible with hacked iPhones. Since there's no jailbreak for iOS 15 or newer, we need a backport :)

Changed deployment target to 14.0, made required edits. Didn't really tested it, because I'm still waiting for my Flipper to arrive (that's why this PR is a draft) UPD: tested, fixed.

@ilyamodder ilyamodder marked this pull request as ready for review November 27, 2022 20:46
@tokfrans03
Copy link

Awesome work!
Just got mine and discovered that the app requires iOS 15 (I have 14.3), and the latest version that supports iOS 14 is 1.0.0.

Thank you open source!

@danpalmer
Copy link

Bumping this because it's been open a long time and we don't want it to bit-rot 😄 . @tonyfreeman (picking you as biggest contributor).

I can understand why the Flipper team might not want to support iOS 14, but also I think "last jailbroken release" is a reasonable compatibility target as @ilyamodder suggested.

Can we get a final say one way or the other? If no, that sounds fine, maybe a note in the readme about the compatibility goal would be a nice clarification. If yes, great! I've reviewed this PR, got a fair bit of Swift(+UI) experience and this all seems reasonable to me, seems ready for a final review with a view to merging.

# Conflicts:
#	Flipper/Flipper.xcodeproj/project.pbxproj
#	Flipper/Packages/Inject/Package.swift
#	Flipper/Packages/UI/Sources/Archive/Emulate/EmulateView.swift
#	Flipper/Packages/UI/Sources/Archive/SaveAs/SaveAsViewModel.swift
#	Flipper/Packages/UI/Sources/Device/Components/Info/DeviceInfoCard.swift
#	Flipper/Packages/UI/Sources/Device/Components/Info/DeviceInfoCardViewModel.swift
#	Flipper/Packages/UI/Sources/Device/Components/Update/DeviceUpdateCard.swift
@pikkio92
Copy link

pikkio92 commented Apr 5, 2023

this is marked as solved but i cannot figure out how to download the ios 14 compatibile .ipa

# Conflicts:
#	Flipper/Flipper.xcodeproj/project.pbxproj
#	Flipper/Packages/UI/Sources/Common/Card/CardRow.swift
#	Flipper/Packages/UI/Sources/Common/UTextField.swift
#	Flipper/Packages/UI/Sources/Device/InfoCard/DeviceInfoCard.swift
#	Flipper/Packages/UI/Sources/RemoteControl/DeviceControls.swift
#	Flipper/Packages/UI/Sources/RootView.swift
# Conflicts:
#	Flipper/Flipper.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts:
#	Flipper/Flipper.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	Flipper/Packages/UI/Package.swift
#	Flipper/Packages/UI/Sources/Archive/NFCEditor/NFCEditorView.swift
#	Flipper/Packages/UI/Sources/Device/DeviceView.swift
#	Flipper/Packages/UI/Sources/Device/InfoCard/DeviceInfoCard.swift
#	Flipper/Packages/UI/Sources/Device/UpdateCard/Components/CardStateReady.swift
# Conflicts:
#	Flipper/Flipper.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	Flipper/Packages/UI/Sources/Hub/Apps/Components/AppScreenshots.swift
#	Flipper/Packages/UI/Sources/Hub/Apps/Components/AppsCategories.swift
#	Flipper/Packages/UI/Sources/Hub/Components/AppIcon.swift
#	Flipper/Packages/UI/Sources/Options/OptionsView.swift
@tonyfreeman
Copy link
Member

Is this still relevant? AFAIK there is jb for iOS15-iOS16.

@tonyfreeman tonyfreeman added the wontfix This will not be worked on label Sep 8, 2023
@tokfrans03
Copy link

Is this still relevant? AFAIK there is jb for iOS15-iOS16.

There is, but because of the nature of jailbreaks there are still some who still have devices on iOS 14 since you usually have to wait months on a specific version before there is a jailbreak publicly available for that version.

# Conflicts:
#	Flipper/Flipper.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	Flipper/Packages/UI/Sources/Archive/NFCEditor/Components/SaveChangesAlert.swift
#	Flipper/Packages/UI/Sources/Device/Update/Components/GitHubMarkdown.swift
#	Flipper/Packages/UI/Sources/Hub/Apps/Components/AppScreenshots.swift
#	Flipper/Packages/UI/Sources/Hub/Apps/Components/AppsSegments.swift
#	Flipper/Packages/UI/Sources/Hub/Components/AppIcon.swift
#	Flipper/Packages/UI/Sources/Options/OptionsView.swift
#	Flipper/Packages/UI/Sources/RootView.swift
@ibboccan
Copy link

I think hacker device's companion app should be compatible with hacked iPhones. Since there's no jailbreak for iOS 15 or newer, we need a backport :)

Changed deployment target to 14.0, made required edits. Didn't really tested it, because I'm still waiting for my Flipper to arrive (that's why this PR is a draft) UPD: tested, fixed.

@tonyfreeman tonyfreeman closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants