Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 rebased #220

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ Lint/UselessAssignment:
Metrics/AbcSize:
Exclude:
- 'lib/deimos/active_record_consume/message_consumption.rb'
- 'lib/deimos/config/phobos_config.rb'
- 'lib/deimos/instrumentation.rb'
- 'lib/deimos/kafka_source.rb'
- 'lib/deimos/kafka_topic_info.rb'
Expand All @@ -159,12 +158,6 @@ Metrics/AbcSize:
- 'lib/deimos/utils/schema_controller_mixin.rb'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline_consumer and schema_controller_mixin can be removed as the files are removed in the PR.

    - 'lib/deimos/utils/inline_consumer.rb'
    - 'lib/deimos/utils/schema_controller_mixin.rb'

- 'lib/generators/deimos/schema_class_generator.rb'

# Offense count: 1
# Configuration parameters: CountComments, Max, CountAsOne, ExcludedMethods.
Metrics/MethodLength:
Exclude:
- 'lib/deimos/config/phobos_config.rb'

# Offense count: 5
# Configuration parameters: CountComments, Max, CountAsOne.
Metrics/ModuleLength:
Expand All @@ -179,7 +172,6 @@ Metrics/ModuleLength:
# Configuration parameters: IgnoredMethods, Max.
Metrics/PerceivedComplexity:
Exclude:
- 'lib/deimos/config/phobos_config.rb'
- 'lib/deimos/consume/batch_consumption.rb'
- 'lib/deimos/kafka_source.rb'
- 'lib/deimos/schema_backends/avro_schema_coercer.rb'
Expand Down Expand Up @@ -253,7 +245,6 @@ Style/FrozenStringLiteralComment:
Style/GlobalStdStream:
Exclude:
- 'lib/deimos/config/configuration.rb'
- 'lib/deimos/config/phobos_config.rb'
- 'lib/deimos/metrics/mock.rb'
- 'lib/deimos/test_helpers.rb'
- 'lib/deimos/tracing/mock.rb'
Expand Down Expand Up @@ -329,14 +320,6 @@ Style/StringLiterals:
- 'spec/schemas/my_namespace/my_schema_with_complex_type.rb'
- 'spec/spec_helper.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
Style/TernaryParentheses:
Exclude:
- 'lib/deimos/config/phobos_config.rb'

# Offense count: 21
# Cop supports --auto-correct.
Style/TrailingBodyOnModule:
Expand Down
1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ruby 3.2.2
Loading
Loading