Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for message headers #194

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

yannp
Copy link
Contributor

@yannp yannp commented Jul 5, 2023

Pull Request Template

Description

Original issue: #192

Currently deimos doesn't support providing :headers to phobos when publishing a message. A monkeypatch prevents it.

Fixes #192 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new specs to cover passing down headers to phobos.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added a line in the CHANGELOG describing this change, under the UNRELEASED heading
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dorner
Copy link
Member

dorner commented Jul 5, 2023

Looks great! Thanks for the contribution!

@dorner dorner merged commit 85ec81d into flipp-oss:master Jul 5, 2023
5 checks passed
@yannp
Copy link
Contributor Author

yannp commented Jul 6, 2023

@dorner I realise that with this PR I didn't address the DB backend properly. This would require to add a headers column to the kafka_messages table. That would be a major update as I understand it. What do you think?

@dorner
Copy link
Member

dorner commented Jul 6, 2023

Hmm... let's see if we can do it wrapped in some checks (respond_to?, checking columns etc.) so it wouldn't break backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not supporting headers?
2 participants