Hibernate Changes #115
Open
Hibernate Changes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2024 10:46
kingster
requested changes
Nov 29, 2024
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class Duration implements Comparable<Duration> { |
There was a problem hiding this comment.
What is the use-case for this Class?
Comment on lines
+32
to
+60
| while (scanner.hasNext()) { | ||
| String next = scanner.next(); | ||
| if (asl.accept(next)) { | ||
| try { | ||
| InputStream in = scanner.open(); | ||
| Throwable var5 = null; | ||
|
|
||
| try { | ||
| asl.process(next, in); | ||
| } catch (Throwable var15) { | ||
| var5 = var15; | ||
| throw var15; | ||
| } finally { | ||
| if (in != null) { | ||
| if (var5 != null) { | ||
| try { | ||
| in.close(); | ||
| } catch (Throwable var14) { | ||
| var5.addSuppressed(var14); | ||
| } | ||
| } else { | ||
| in.close(); | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } catch (IOException var17) { | ||
| throw new RuntimeException("AnnotationAcceptingListener failed to process scanned resource: " + next); | ||
| } |
There was a problem hiding this comment.
Where is this code coming from? If we are coping code, why can't we use that library itself, otherwise lets use the right variable names and give attribution to the sources.
Comment on lines
+58
to
+65
| Iterator var7 = properties.entrySet().iterator(); | ||
|
|
||
| while (var7.hasNext()) { | ||
| Map.Entry<String, String> property = (Map.Entry) var7.next(); | ||
| configuration.setProperty((String) property.getKey(), (String) property.getValue()); | ||
| } | ||
|
|
||
| this.addAnnotatedClasses(configuration, entities); |
Comment on lines
+79
to
+84
| while (var4.hasNext()) { | ||
| Class<?> klass = (Class) var4.next(); | ||
| configuration.addAnnotatedClass(klass); | ||
| entityClasses.add(klass.getCanonicalName()); | ||
| } | ||
|
|
Comment on lines
+39
to
+70
| Throwable var2 = null; | ||
|
|
||
| try { | ||
| Transaction txn = session.beginTransaction(); | ||
|
|
||
| try { | ||
| session.createSQLQuery(this.validationQuery).list(); | ||
| txn.commit(); | ||
| } catch (Exception var13) { | ||
| if (txn.getStatus().canRollback()) { | ||
| txn.rollback(); | ||
| } | ||
|
|
||
| throw var13; | ||
| } | ||
| } catch (Throwable var14) { | ||
| var2 = var14; | ||
| throw var14; | ||
| } finally { | ||
| if (session != null) { | ||
| if (var2 != null) { | ||
| try { | ||
| session.close(); | ||
| } catch (Throwable var12) { | ||
| var2.addSuppressed(var12); | ||
| } | ||
| } else { | ||
| session.close(); | ||
| } | ||
| } | ||
|
|
||
| } |
| import java.util.Map; | ||
|
|
||
| @Provider | ||
| public class UnitOfWorkApplicationListener implements ApplicationEventListener { |
There was a problem hiding this comment.
What is the usecase of this class? What functionality does it provide?
|
|
||
| import java.util.Map; | ||
|
|
||
| class UnitOfWorkAspect { |
There was a problem hiding this comment.
What functionality does this provide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.