Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9998: refactor suggestion #10138

Merged
merged 4 commits into from
Sep 5, 2023
Merged

9998: refactor suggestion #10138

merged 4 commits into from
Sep 5, 2023

Conversation

mmarcotte
Copy link
Collaborator

Suggestion to rename and refactor persistence function to be more representative of what it is doing.

  1. change the name getCasesByEventCodes to getDocketNumbersWithServedEventCodes.
  2. made the array of cases optional, which would only be assumed before.
  3. set the response type to be an array of strings (docket numbers) since that is what is specified in the _source rather than an array of objects whose only property is docketNumber.

jasonfu9966
jasonfu9966 approved these changes Aug 30, 2023
View reviewed changes
Copy link

@jasonfu9966 jasonfu9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Absolutestunna Absolutestunna merged commit aba6794 into flexion:9998-full-run-for-all-judges Sep 5, 2023
34 checks passed
@jimlerza jimlerza deleted the 9998-full-run-for-all-judges-refactor branch November 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomElliottFlexion TomElliottFlexion TomElliottFlexion approved these changes

@jasonfu9966 jasonfu9966 jasonfu9966 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmarcotte @jasonfu9966 @TomElliottFlexion @Absolutestunna