9970: Create a TrialSessionFactory and multiple trial session types t…

…o better handle operations that are unique to a trial session status.
flexion · Jul 4, 2023 · 1a638da · 1a638da
1 parent b11902f
commit 1a638da
Show file tree

Hide file tree

Showing 50 changed files with 586 additions and 651 deletions.
diff --git a/shared/src/business/entities/cases/Case.isHearing.test.ts b/shared/src/business/entities/cases/Case.isHearing.test.ts
@@ -1,13 +1,13 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('isHearing', () => {
   it('checks if the given trialSessionId is a hearing (true)', () => {
-    const trialSessionHearing = new TrialSession(
+    const trialSessionHearing = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -18,7 +18,7 @@ describe('isHearing', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     const caseToUpdate = new Case(
       {
@@ -36,7 +36,7 @@ describe('isHearing', () => {
   });
 
   it('checks if the given trialSessionId is a hearing (false)', () => {
-    const trialSessionHearing = new TrialSession(
+    const trialSessionHearing = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -47,7 +47,7 @@ describe('isHearing', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     const caseToUpdate = new Case(
       {

diff --git a/shared/src/business/entities/cases/Case.removeFromHearing.test.ts b/shared/src/business/entities/cases/Case.removeFromHearing.test.ts
@@ -1,13 +1,13 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('removeFromHearing', () => {
   it('removes the hearing from the case', () => {
-    const trialSessionHearing = new TrialSession(
+    const trialSessionHearing = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -18,7 +18,7 @@ describe('removeFromHearing', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     const caseToUpdate = new Case(
       {

diff --git a/shared/src/business/entities/cases/Case.removeFromTrial.test.ts b/shared/src/business/entities/cases/Case.removeFromTrial.test.ts
@@ -1,10 +1,10 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { CASE_STATUS_TYPES, CHIEF_JUDGE } = require('../EntityConstants');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('removeFromTrial', () => {
   it('removes the case from trial, unsetting trial details and setting status to general docket ready for trial', () => {
@@ -16,7 +16,7 @@ describe('removeFromTrial', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -27,7 +27,7 @@ describe('removeFromTrial', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     const user = 'Petitions Clerk';
 
@@ -68,7 +68,7 @@ describe('removeFromTrial', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -79,7 +79,7 @@ describe('removeFromTrial', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     caseToUpdate.setAsCalendared(trialSession);
 
@@ -105,7 +105,7 @@ describe('removeFromTrial', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -116,7 +116,7 @@ describe('removeFromTrial', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     caseToUpdate.setAsCalendared(trialSession);
 

diff --git a/shared/src/business/entities/cases/Case.removeFromTrialWithAssociatedJudge.test.ts b/shared/src/business/entities/cases/Case.removeFromTrialWithAssociatedJudge.test.ts
@@ -1,10 +1,10 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { CASE_STATUS_TYPES } = require('../EntityConstants');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('removeFromTrialWithAssociatedJudge', () => {
   it('removes the case from trial, updating the associated judge if one is passed in', () => {
@@ -16,7 +16,7 @@ describe('removeFromTrialWithAssociatedJudge', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -27,7 +27,7 @@ describe('removeFromTrialWithAssociatedJudge', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     caseToUpdate.setAsCalendared(trialSession);
 
@@ -56,7 +56,7 @@ describe('removeFromTrialWithAssociatedJudge', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -67,7 +67,7 @@ describe('removeFromTrialWithAssociatedJudge', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     caseToUpdate.setAsCalendared(trialSession);
 

diff --git a/shared/src/business/entities/cases/Case.setAsCalendared.test.ts b/shared/src/business/entities/cases/Case.setAsCalendared.test.ts
@@ -1,10 +1,10 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { CASE_STATUS_TYPES, CHIEF_JUDGE } = require('../EntityConstants');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('setAsCalendared', () => {
   it('should set case as calendared with only judge and trialSessionId if the trial session is calendared', () => {
@@ -31,7 +31,7 @@ describe('setAsCalendared', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -42,7 +42,7 @@ describe('setAsCalendared', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     myCase.setAsCalendared(trialSession);
 
@@ -63,7 +63,7 @@ describe('setAsCalendared', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: false,
         judge: { name: 'Judge Buch' },
@@ -74,7 +74,7 @@ describe('setAsCalendared', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     myCase.setAsCalendared(trialSession);
 

diff --git a/shared/src/business/entities/cases/Case.ts b/shared/src/business/entities/cases/Case.ts
@@ -45,7 +45,7 @@ import { Petitioner } from '../contacts/Petitioner';
 import { PrivatePractitioner } from '../PrivatePractitioner';
 import { PublicCase } from './PublicCase';
 import { Statistic } from '../Statistic';
-import { TrialSession } from '../trialSessions/TrialSession';
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 import { UnprocessableEntityError } from '../../../errors/errors';
 import { User } from '../User';
 import { clone, compact, includes, isEmpty, startCase } from 'lodash';
@@ -862,7 +862,7 @@ export class Case extends JoiValidationEntity {
   assignHearings({ applicationContext, rawCase }) {
     if (Array.isArray(rawCase.hearings)) {
       this.hearings = rawCase.hearings
-        .map(hearing => new TrialSession(hearing, { applicationContext }))
+        .map(hearing => TrialSessionFactory(hearing, applicationContext))
         .sort((a, b) => compareStrings(a.createdAt, b.createdAt));
     } else {
       this.hearings = [];

diff --git a/shared/src/business/entities/cases/Case.updateTrialSessionInformation.test.ts b/shared/src/business/entities/cases/Case.updateTrialSessionInformation.test.ts
@@ -1,10 +1,10 @@
+import { TrialSessionFactory } from '../trialSessions/TrialSessionFactory';
 const {
   applicationContext,
 } = require('../../test/createTestApplicationContext');
 const { Case } = require('./Case');
 const { CASE_STATUS_TYPES, CHIEF_JUDGE } = require('../EntityConstants');
 const { MOCK_CASE } = require('../../../test/mockCase');
-const { TrialSession } = require('../trialSessions/TrialSession');
 
 describe('updateTrialSessionInformation', () => {
   it('should not change the status of the case', () => {
@@ -47,7 +47,7 @@ describe('updateTrialSessionInformation', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: true,
         judge: { name: 'Judge Buch' },
@@ -58,7 +58,7 @@ describe('updateTrialSessionInformation', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     myCase.updateTrialSessionInformation(trialSession);
 
@@ -78,7 +78,7 @@ describe('updateTrialSessionInformation', () => {
         applicationContext,
       },
     );
-    const trialSession = new TrialSession(
+    const trialSession = TrialSessionFactory(
       {
         isCalendared: false,
         judge: { name: 'Judge Buch' },
@@ -89,7 +89,7 @@ describe('updateTrialSessionInformation', () => {
         termYear: '2025',
         trialLocation: 'Birmingham, Alabama',
       },
-      { applicationContext },
+      applicationContext,
     );
     myCase.setAsCalendared(trialSession);
 

diff --git a/shared/src/business/entities/trialSessions/ClosedTrialSession.ts b/shared/src/business/entities/trialSessions/ClosedTrialSession.ts
@@ -0,0 +1,12 @@
+import { SESSION_STATUS_TYPES } from '../EntityConstants';
+import { TrialSession } from './TrialSession';
+
+export class ClosedTrialSession extends TrialSession {
+  constructor(rawSession: RawClosedTrialSession) {
+    super(rawSession);
+
+    this.sessionStatus = SESSION_STATUS_TYPES.closed;
+  }
+}
+
+export type RawClosedTrialSession = ExcludeMethods<ClosedTrialSession>;
diff --git a/shared/src/business/entities/trialSessions/NewTrialSession.ts b/shared/src/business/entities/trialSessions/NewTrialSession.ts
@@ -1,14 +1,19 @@
 import { JoiValidationConstants } from '../JoiValidationConstants';
+import { OpenTrialSession } from './OpenTrialSession';
+import { SESSION_STATUS_TYPES } from '../EntityConstants';
 import { TrialSession } from './TrialSession';
 import joi from 'joi';
 
 export class NewTrialSession extends TrialSession {
-  public trialClerkId: string;
+  public trialClerkId?: string;
 
   constructor(rawSession: RawNewTrialSession, { applicationContext }) {
-    super(rawSession, { applicationContext });
+    super(rawSession);
 
     this.trialClerkId = rawSession.trialClerkId;
+    this.trialSessionId =
+      rawSession.trialSessionId || applicationContext.getUniqueId();
+    this.sessionStatus = SESSION_STATUS_TYPES.new;
   }
 
   getErrorToMessageMap() {
@@ -21,7 +26,7 @@ export class NewTrialSession extends TrialSession {
 
   getValidationRules() {
     return {
-      ...TrialSession.validationRules.COMMON,
+      ...TrialSession.VALIDATION_RULES,
       alternateTrialClerkName: joi.when('trialClerkId', {
         is: 'Other',
         otherwise: joi.optional(),
@@ -30,6 +35,12 @@ export class NewTrialSession extends TrialSession {
       startDate: JoiValidationConstants.ISO_DATE.min('now').required(),
     };
   }
+
+  setAsCalendared(): OpenTrialSession {
+    this.isCalendared = true;
+    this.sessionStatus = SESSION_STATUS_TYPES.open;
+    return new OpenTrialSession(this);
+  }
 }
 
 export type RawNewTrialSession = ExcludeMethods<NewTrialSession>;