Skip to content

docs[webapi]: add missing webapi methods to docs and reorganize sections #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

yaugenst-flex
Copy link
Collaborator

@yaugenst-flex yaugenst-flex commented Jun 20, 2025

Greptile Summary

Documentation improvements for Web API methods, focusing on better organization and type annotations in the Tidy3D codebase.

  • Added precise return type annotations for get_run_info() and abort() in tidy3d/web/api/webapi.py
  • Enhanced docstrings for account() and test() functions with comprehensive sections (Parameters, Returns, Examples)
  • Restructured docs/api/submit_simulations.rst into logical sections (Core Workflow, Download Utilities, etc.)
  • Added documentation for previously undocumented API methods like download_hdf5, get_run_info, and get_tasks

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/docs-gettask branch from 869a14e to 744a69a Compare June 20, 2025 08:47
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

  • tidy3d/web/api/webapi.py (100%)

Summary

  • Total: 2 lines
  • Missing: 0 lines
  • Coverage: 100%

Copy link
Collaborator

@e-g-melo e-g-melo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yaugenst-flex! It sounds very good to me!

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/docs-gettask branch from 744a69a to 746e9d8 Compare June 21, 2025 17:54
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/docs-gettask branch from 746e9d8 to 960330e Compare June 23, 2025 11:10
@yaugenst-flex yaugenst-flex enabled auto-merge (rebase) June 23, 2025 11:10
@yaugenst-flex yaugenst-flex merged commit e824ac6 into develop Jun 23, 2025
20 of 23 checks passed
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/docs-gettask branch June 23, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants