Tests for simulation reduction in upload()
#2587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+299
to
+300
| uploaded_sim = mock_upload["stub"].simulation | ||
| assert uploaded_sim == expected_sim |
There was a problem hiding this comment.
style: Consider adding a failure message to the assertion to clarify the error when the test fails
There was a problem hiding this comment.
Good suggestion in principle but in this test it's quite obvious what would be failing so not necessary I would say.
momchil-flex
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for #2583 @momchil-flex
Greptile Summary
Added test coverage for simulation reduction during upload in
test_webapi_mode.pyandtest_webapi_mode_sim.py.test_upload_with_reduction_parameterto verify simulation reduction behaviormock_uploadfixture to track and expose uploaded simulation stubs for verificationreduce_simulation=Trueandreduce_simulation=False