-
Notifications
You must be signed in to change notification settings - Fork 58
Electric field monitor for Charge #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
tidy3d/components/data/unstructured/base.py
|
a22f358
to
8ff1ec8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
"""Return copy of self with symmetry applied.""" | ||
|
||
new_Ex = self._symmetry_expanded_copy(property=self.Ex) | ||
new_Ey = self._symmetry_expanded_copy(property=self.Ey) | ||
new_Ez = self._symmetry_expanded_copy(property=self.Ez) | ||
|
||
return self.updated_copy( | ||
Ex=new_Ex, | ||
Ey=new_Ey, | ||
Ez=new_Ez, | ||
symmetry=(0, 0, 0), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: No validation for correct data type (IndexedVoltageDataArray) unlike SteadyFreeCarrierData and SteadyEnergyBandData
Monitor tests
61b4a48
to
50d69e3
Compare
Greptile Summary
Adds electric field monitoring capabilities to the Charge simulation module, enabling visualization and analysis of steady-state electric fields through a new
SteadyElectricFieldMonitor
class and associated data structures.SteadyElectricFieldMonitor
intidy3d/components/tcad/monitors/charge.py
to monitor Ex, Ey, Ez componentsSteadyElectricFieldData
class intidy3d/components/tcad/data/monitor_data/charge.py
handling electric field data with proper unit conversion (V/μm)_cell_to_point_data
utility inUnstructuredGridDataset
for VTK-based cell-to-point data conversion