XY transposable sim.plot() plots (issue1072) VERSION 2

tests/test_components/test_eme.py

@@ -283,21 +283,22 @@ def test_eme_monitor():
     )
 
 
-def test_eme_simulation():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_eme_simulation(transpose):
     sim = make_eme_sim()
-    _ = sim.plot(x=0, ax=AX)
-    _ = sim.plot(y=0, ax=AX)
-    _ = sim.plot(z=0, ax=AX)
-    _ = sim.plot_grid(x=0, ax=AX)
-    _ = sim.plot_grid(y=0, ax=AX)
-    _ = sim.plot_grid(z=0, ax=AX)
-    _ = sim.plot_eps(x=0, ax=AX)
-    _ = sim.plot_eps(y=0, ax=AX)
-    _ = sim.plot_eps(z=0, ax=AX)
+    _ = sim.plot(x=0, ax=AX, transpose=transpose)
+    _ = sim.plot(y=0, ax=AX, transpose=transpose)
+    _ = sim.plot(z=0, ax=AX, transpose=transpose)
+    _ = sim.plot_grid(x=0, ax=AX, transpose=transpose)
+    _ = sim.plot_grid(y=0, ax=AX, transpose=transpose)
+    _ = sim.plot_grid(z=0, ax=AX, transpose=transpose)
+    _ = sim.plot_eps(x=0, ax=AX, transpose=transpose)
+    _ = sim.plot_eps(y=0, ax=AX, transpose=transpose)
+    _ = sim.plot_eps(z=0, ax=AX, transpose=transpose)
     sim2 = sim.updated_copy(axis=1)
-    _ = sim2.plot(x=0, ax=AX)
-    _ = sim2.plot(y=0, ax=AX)
-    _ = sim2.plot(z=0, ax=AX)
+    _ = sim2.plot(x=0, ax=AX, transpose=transpose)
+    _ = sim2.plot(y=0, ax=AX, transpose=transpose)
+    _ = sim2.plot(z=0, ax=AX, transpose=transpose)
 
     # need at least one freq
     with pytest.raises(pd.ValidationError):

tests/test_components/test_geometry.py

@@ -85,14 +85,15 @@
 _, AX = plt.subplots()
 
 
-@pytest.mark.parametrize("component", GEO_TYPES)
-def test_plot(component):
-    _ = component.plot(z=0, ax=AX)
+@pytest.mark.parametrize("component, transpose", zip(GEO_TYPES, [True, False]))
+def test_plot(component, transpose):
+    _ = component.plot(z=0, ax=AX, transpose=transpose)
     plt.close()
 
 
-def test_plot_with_units():
-    _ = BOX.plot(z=0, ax=AX, plot_length_units="nm")
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_with_units(transpose):
+    _ = BOX.plot(z=0, ax=AX, plot_length_units="nm", transpose=transpose)
     plt.close()
 
 
@@ -204,11 +205,11 @@ def test_array_to_vertices():
     assert np.all(np.array(vertices) == np.array(vertices2))
 
 
-@pytest.mark.parametrize("component", GEO_TYPES)
-def test_intersections_plane(component):
-    assert len(component.intersections_plane(z=0.2)) > 0
-    assert len(component.intersections_plane(x=0.2)) > 0
-    assert len(component.intersections_plane(x=10000)) == 0
+@pytest.mark.parametrize("component, transpose", zip(GEO_TYPES, [True, False]))
+def test_intersections_plane(component, transpose):
+    assert len(component.intersections_plane(z=0.2, transpose=transpose)) > 0
+    assert len(component.intersections_plane(x=0.2, transpose=transpose)) > 0
+    assert len(component.intersections_plane(x=10000, transpose=transpose)) == 0
 
 
 def test_intersections_plane_inf():
@@ -766,36 +767,49 @@ def test_geometry_touching_intersections_plane(x0):
 
 
 def test_pop_axis():
-    b = td.Box(size=(1, 1, 1))
     for axis in range(3):
         coords = (1, 2, 3)
-        Lz, (Lx, Ly) = b.pop_axis(coords, axis=axis)
-        _coords = b.unpop_axis(Lz, (Lx, Ly), axis=axis)
+        Lz, (Lx, Ly) = td.Box.pop_axis(coords, axis=axis)
+        _coords = td.Box.unpop_axis(Lz, (Lx, Ly), axis=axis)
+        assert all(c == _c for (c, _c) in zip(coords, _coords))
+        _Lz, (_Lx, _Ly) = td.Box.pop_axis(_coords, axis=axis)
+        assert Lz == _Lz
+        assert Lx == _Lx
+        assert Ly == _Ly
+
+
+@pytest.mark.parametrize("transpose", [True, False])
+def test_pop_axis_and_swap(transpose):
+    for axis in range(3):
+        coords = (1, 2, 3)
+        Lz, (Lx, Ly) = td.Box.pop_axis_and_swap(coords, axis=axis, transpose=transpose)
+        _coords = td.Box.unpop_axis_and_swap(Lz, (Lx, Ly), axis=axis, transpose=transpose)
         assert all(c == _c for (c, _c) in zip(coords, _coords))
-        _Lz, (_Lx, _Ly) = b.pop_axis(_coords, axis=axis)
+        _Lz, (_Lx, _Ly) = td.Box.pop_axis_and_swap(_coords, axis=axis, transpose=transpose)
         assert Lz == _Lz
         assert Lx == _Lx
         assert Ly == _Ly
 
 
-def test_2b_box_intersections():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_2b_box_intersections(transpose):
     plane = td.Box(size=(1, 4, 0))
     box1 = td.Box(size=(1, 1, 1))
     box2 = td.Box(size=(1, 1, 1), center=(3, 0, 0))
 
-    result = plane.intersections_with(box1)
+    result = plane.intersections_with(box1, transpose=transpose)
     assert len(result) == 1
     assert result[0].geom_type == "Polygon"
-    assert len(plane.intersections_with(box2)) == 0
+    assert len(plane.intersections_with(box2, transpose=transpose)) == 0
 
     with pytest.raises(ValidationError):
-        _ = box1.intersections_with(box2)
+        _ = box1.intersections_with(box2, transpose=transpose)
 
-    assert len(box1.intersections_2dbox(plane)) == 1
-    assert len(box2.intersections_2dbox(plane)) == 0
+    assert len(box1.intersections_2dbox(plane, transpose=transpose)) == 1
+    assert len(box2.intersections_2dbox(plane, transpose=transpose)) == 0
 
     with pytest.raises(ValidationError):
-        _ = box2.intersections_2dbox(box1)
+        _ = box2.intersections_2dbox(box1, transpose=transpose)
 
 
 def test_polyslab_merge():
@@ -937,7 +951,8 @@ def test_to_gds(geometry, tmp_path):
     assert len(cell.polygons) == 0
 
 
-def test_custom_surface_geometry(tmp_path):
+@pytest.mark.parametrize("transpose", [True, False])
+def test_custom_surface_geometry(transpose, tmp_path):
     # create tetrahedron STL
     vertices = np.array([[0, 0, 0], [1, 0, 0], [0, 1, 0], [0, 0, 1]])
     faces = np.array([[1, 2, 3], [0, 3, 2], [0, 1, 3], [0, 2, 1]])
@@ -970,9 +985,13 @@ def test_custom_surface_geometry(tmp_path):
     assert np.isclose(geom.volume(), 1 / 6)
 
     # test intersections
-    assert shapely.equals(geom.intersections_plane(x=0), shapely.Polygon([[0, 0], [0, 1], [1, 0]]))
     assert shapely.equals(
-        geom.intersections_plane(z=0.5), shapely.Polygon([[0, 0], [0, 0.5], [0.5, 0]])
+        geom.intersections_plane(x=0, transpose=transpose),
+        shapely.Polygon([[0, 0], [0, 1], [1, 0]]),
+    )
+    assert shapely.equals(
+        geom.intersections_plane(z=0.5, transpose=transpose),
+        shapely.Polygon([[0, 0], [0, 0.5], [0.5, 0]]),
     )
 
     # test inside
@@ -981,7 +1000,7 @@ def test_custom_surface_geometry(tmp_path):
 
     # test plot
     _, ax = plt.subplots()
-    _ = geom.plot(z=0.1, ax=ax)
+    _ = geom.plot(z=0.1, ax=ax, transpose=transpose)
     plt.close()
 
     # test inconsistent winding
@@ -1031,7 +1050,7 @@ def test_custom_surface_geometry(tmp_path):
         boundary_spec=td.BoundarySpec.all_sides(td.PML()),
     )
     _, ax = plt.subplots()
-    _ = sim.plot(y=0, ax=ax)
+    _ = sim.plot(y=0, ax=ax, transpose=transpose)
     plt.close()
 
     # allow small triangles

tests/test_components/test_heat.py

@@ -335,11 +335,12 @@ def make_heat_sim(include_custom_source: bool = True):
     return heat_sim
 
 
-def test_heat_sim():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_heat_sim(transpose):
     bc_temp, bc_flux, bc_conv = make_heat_bcs()
     heat_sim = make_heat_sim()
 
-    _ = heat_sim.plot(x=0)
+    _ = heat_sim.plot(x=0, transpose=transpose)
 
     # wrong names given
     for pl in [
@@ -373,14 +374,14 @@ def test_heat_sim():
     with pytest.raises(pd.ValidationError):
         heat_sim.updated_copy(monitors=[temp_mnt, temp_mnt])
 
-    _ = heat_sim.plot(x=0)
+    _ = heat_sim.plot(x=0, transpose=transpose)
     plt.close()
 
-    _ = heat_sim.plot_heat_conductivity(y=0)
+    _ = heat_sim.plot_heat_conductivity(y=0, transpose=transpose)
     plt.close()
 
     heat_sim_sym = heat_sim.updated_copy(symmetry=(0, 1, 1))
-    _ = heat_sim_sym.plot_heat_conductivity(z=0, colorbar="source")
+    _ = heat_sim_sym.plot_heat_conductivity(z=0, colorbar="source", transpose=transpose)
     plt.close()
 
     # no negative symmetry

tests/test_components/test_heat_charge.py

@@ -852,7 +852,8 @@ def test_heat_charge_sources(structures):
         _ = td.HeatSource(structures=["solid_structure"], rate="100")
 
 
-def test_heat_charge_simulation(simulation_data):
+@pytest.mark.parametrize("transpose", [True, False])
+def test_heat_charge_simulation(transpose, simulation_data):
     """Tests 'HeatChargeSimulation' and 'ConductionSimulation' objects."""
     heat_sim_data, cond_sim_data, voltage_capacitance_sim_data, current_voltage_simulation_data = (
         simulation_data
@@ -876,6 +877,18 @@ def test_heat_charge_simulation(simulation_data):
         "Current-Voltage simulation should be created successfully."
     )
 
+    _ = heat_sim.plot_heat_conductivity(x=0, transpose=transpose)
+    plt.close()
+    _ = heat_sim.plot_property(x=0, property="heat_conductivity", transpose=transpose)
+    plt.close()
+    _ = cond_sim.plot_property(x=0, property="electric_conductivity", transpose=transpose)
+    plt.close()
+    for sim in (heat_sim, cond_sim, voltage_capacitance_sim, current_voltage_sim):
+        _ = sim.plot_boundaries(x=0, transpose=transpose)
+        plt.close()
+        _ = sim.plot_sources(x=0, transpose=transpose)
+        plt.close()
+
 
 def test_sim_data_plotting(simulation_data):
     """Tests whether simulation data can be plotted and appropriate errors are raised."""
@@ -1433,7 +1446,8 @@ def test_plotting_functions(simulation_data):
         heat_sim_data.plot_field("test", invalid_param=0)
 
 
-def test_bandgap_monitor():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_bandgap_monitor(transpose):
     """Test energy bandgap monitor ploting function."""
     # create a triangle grid
     tri_grid_points = td.PointDataArray(
@@ -1573,8 +1587,8 @@ def test_bandgap_monitor():
 
     # test check for the voltage value in the list of arguments
 
-    tri_single_voltage_data.plot(x=0.0)
-    tri_multi_voltage_data.plot(x=0.0, voltage=1.0)
+    tri_single_voltage_data.plot(x=0.0, transpose=transpose)
+    tri_multi_voltage_data.plot(x=0.0, voltage=1.0, transpose=transpose)
 
     with pytest.raises(DataError):
         tri_multi_voltage_data.plot(x=0.0)

tests/test_components/test_scene.py

@@ -50,13 +50,15 @@ def test_validate_components_none():
     assert SCENE._validate_num_mediums(val=None) is None
 
 
-def test_plot_eps():
-    ax = SCENE_FULL.plot_eps(x=0)
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_eps(transpose):
+    ax = SCENE_FULL.plot_eps(x=0, transpose=transpose)
     SCENE_FULL._add_cbar_eps(eps_min=1, eps_max=2, ax=ax)
     plt.close()
 
 
-def test_plot_eps_multiphysics():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_eps_multiphysics(transpose):
     s = td.Scene(
         structures=[
             td.Structure(
@@ -70,20 +72,22 @@ def test_plot_eps_multiphysics():
         ]
     )
     assert s.structures[0].medium.name == "SiO2"
-    s.plot_eps(x=0)
+    s.plot_eps(x=0, transpose=transpose)
 
 
-def test_plot_eps_bounds():
-    _ = SCENE_FULL.plot_eps(x=0, hlim=[-0.45, 0.45])
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_eps_bounds(transpose):
+    _ = SCENE_FULL.plot_eps(x=0, hlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_eps(x=0, vlim=[-0.45, 0.45])
+    _ = SCENE_FULL.plot_eps(x=0, vlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_eps(x=0, hlim=[-0.45, 0.45], vlim=[-0.45, 0.45])
+    _ = SCENE_FULL.plot_eps(x=0, hlim=[-0.45, 0.45], vlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
 
 
-def test_plot():
-    SCENE_FULL.plot(x=0)
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot(transpose):
+    SCENE_FULL.plot(x=0, transpose=transpose)
     plt.close()
 
 
@@ -93,44 +97,48 @@ def test_plot_1d_scene():
     plt.close()
 
 
-def test_plot_bounds():
-    _ = SCENE_FULL.plot(x=0, hlim=[-0.45, 0.45])
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_bounds(transpose):
+    _ = SCENE_FULL.plot(x=0, hlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot(x=0, vlim=[-0.45, 0.45])
+    _ = SCENE_FULL.plot(x=0, vlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot(x=0, hlim=[-0.45, 0.45], vlim=[-0.45, 0.45])
+    _ = SCENE_FULL.plot(x=0, hlim=[-0.45, 0.45], vlim=[-0.45, 0.45], transpose=transpose)
     plt.close()
 
 
-def test_structure_alpha():
-    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=None)
+@pytest.mark.parametrize("transpose", [True, False])
+def test_structure_alpha(transpose):
+    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=None, transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=-1)
+    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=-1, transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=1)
+    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=1, transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=0.5)
+    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=0.5, transpose=transpose)
     plt.close()
-    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=0.5, cbar=True)
+    _ = SCENE_FULL.plot_structures_eps(x=0, alpha=0.5, cbar=True, transpose=transpose)
     plt.close()
     new_structs = [
         td.Structure(geometry=s.geometry, medium=SCENE_FULL.medium) for s in SCENE_FULL.structures
     ]
     S2 = SCENE_FULL.copy(update={"structures": new_structs})
-    _ = S2.plot_structures_eps(x=0, alpha=0.5)
+    _ = S2.plot_structures_eps(x=0, alpha=0.5, transpose=transpose)
     plt.close()
 
 
-def test_plot_with_units():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_plot_with_units(transpose):
     scene_with_units = SCENE_FULL.updated_copy(plot_length_units="nm")
-    scene_with_units.plot(x=-0.5)
+    scene_with_units.plot(x=-0.5, transpose=transpose)
 
 
-def test_filter_structures():
+@pytest.mark.parametrize("transpose", [True, False])
+def test_filter_structures(transpose):
     s1 = td.Structure(geometry=td.Box(size=(1, 1, 1)), medium=SCENE.medium)
     s2 = td.Structure(geometry=td.Box(size=(1, 1, 1), center=(1, 1, 1)), medium=SCENE.medium)
     plane = td.Box(center=(0, 0, 1.5), size=(td.inf, td.inf, 0))
-    SCENE._filter_structures_plane_medium(structures=[s1, s2], plane=plane)
+    SCENE._filter_structures_plane_medium(structures=[s1, s2], plane=plane, transpose=transpose)
 
 
 def test_get_structure_plot_params():