-
Notifications
You must be signed in to change notification settings - Fork 55
Fix:Error message for invalid task ID #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b55cbb0
to
0428080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rahul-flex! This is going in the right direction but we should try to handle 404 errors more generally.
61f4c3b
to
d46649b
Compare
03884b5
to
6b86fa0
Compare
Closes #2154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rahul-flex looks good to go from my side, minus the little changelog clarification.
@QingengWei could you have a look? This addresses the discussion in #2154. The The old |
@rahul-flex I think this is good to go after the small change in the changelog. could you rebase? |
e604275
to
29fa604
Compare
Previously, when web.load received a 404 response for an invalid or non-existent task ID, the client would return None and produce unhelpful error messages. This commit changes that behavior: it now raises a TaskNotFoundError with a clear, user-friendly explanation.
