Skip to content

Commit

Permalink
refactor!: refactor the utils directory
Browse files Browse the repository at this point in the history
A third commit in a series of major refactors, this time it greatly
simplifies the utils directory, both in terms of code readability and in
terms of application logic.

Since the things defined inside of utils are used throughout the entire
codebase, this commit also introduces significant changes outside of the
utils directory.

BREAKING CHANGE: This commit changes the settings schema, which means
that a lot of the settings will have to be reset when the extension is
upgraded.

BREAKING CHANGE: The code that manually disabled shadows for X11 windows
has been removed, since it uses GNOME APIs which weren't supposed to be
public and which will are now removed[1]. I didn't notice any issues
after this change, but they may happen in the future.

[1]: https://gitlab.gnome.org/GNOME/mutter/-/commit/0104fbe577594bcc7fdc965be323be08e4bd35d0
  • Loading branch information
flexagoon committed Sep 14, 2024
1 parent a7c72fd commit 0ace2ff
Show file tree
Hide file tree
Showing 54 changed files with 1,501 additions and 1,699 deletions.
3 changes: 1 addition & 2 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"style": {
"noNamespaceImport": "off",
"noDefaultExport": "off",
"useNamingConvention": "off",
"useSingleCaseStatement": "off"
"useNamingConvention": "off"
},
"performance": {
"noDelete": "off"
Expand Down
39 changes: 19 additions & 20 deletions po/ar.po
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ msgid ""
msgstr ""
"Project-Id-Version: 12\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-07-22 11:54-0700\n"
"POT-Creation-Date: 2024-09-14 21:07+0300\n"
"PO-Revision-Date: 2023-12-10 10:05+0000\n"
"Last-Translator: Nadjib Chergui <[email protected]>\n"
"Language-Team: Arabic <https://hosted.weblate.org/projects/rounded-window-"
Expand Down Expand Up @@ -140,7 +140,7 @@ msgid "Debug"
msgstr "تصحيح الأخطاء"

#: src/preferences/pages/general.ui:174
#: src/preferences/widgets/reset_page.ts:61
#: src/preferences/widgets/reset_page.ts:64
msgid "Enable Log"
msgstr "تفعيل التسجيلات التقنية"

Expand Down Expand Up @@ -258,17 +258,17 @@ msgstr ""
msgid "_Reset"
msgstr ""

#: src/preferences/widgets/app_row.ts:28
#: src/preferences/widgets/app_row.ts:27
#, fuzzy
msgid "Window class"
msgstr "ظل النافذة"

#: src/preferences/widgets/app_row.ts:48
#: src/preferences/widgets/app_row.ts:47
#, fuzzy
msgid "Expand this row, to pick a window"
msgstr "كبر الصف لاختيار نافذة."

#: src/preferences/widgets/app_row.ts:92
#: src/preferences/widgets/app_row.ts:86
#, fuzzy
msgid "Can't pick window from this position"
msgstr "لا يمكن اختيار النافذة من هذا المكان"
Expand Down Expand Up @@ -298,55 +298,54 @@ msgstr "إبقاء الزوايا المدورة في وضع ملء الشاشة
msgid "Always clip rounded corners even for fullscreen window"
msgstr "إبقاء الزوايا المدورة في حال النافذة في وضع ملء الشاشة."

#: src/preferences/widgets/reset_page.ts:54
#: src/preferences/widgets/reset_page.ts:57
msgid "Skip LibAdwaita Applications"
msgstr "تجنب تطبيقات (LibAdwaita)"

#: src/preferences/widgets/reset_page.ts:56
#: src/preferences/widgets/reset_page.ts:59
msgid "Skip LibHandy Applications"
msgstr "تجنب تطبيقات (LibHandy)"

#: src/preferences/widgets/reset_page.ts:57
#: src/preferences/widgets/reset_page.ts:60
msgid "Focus Window Shadow Style"
msgstr "نمط ظل النافذة المختارة"

#: src/preferences/widgets/reset_page.ts:58
#: src/preferences/widgets/reset_page.ts:61
msgid "Unfocus Window Shadow Style"
msgstr "نمط ظل النافذة الغير المختارة"

#: src/preferences/widgets/reset_page.ts:59
#: src/preferences/widgets/reset_page.ts:62
#, fuzzy
msgid "Border Width"
msgstr "عرض الحدود"

#: src/preferences/widgets/reset_page.ts:60
#: src/preferences/widgets/reset_page.ts:63
msgid "Border Color"
msgstr "لون الحدود"

#: src/preferences/widgets/reset_page.ts:65
#: src/preferences/widgets/reset_page.ts:68
msgid "Border Radius"
msgstr "درجة تدوير زوايا الحدود"

#: src/preferences/widgets/reset_page.ts:66
#: src/preferences/widgets/reset_page.ts:69
msgid "Padding"
msgstr "تباعد"

#: src/preferences/widgets/reset_page.ts:68
#: src/preferences/widgets/reset_page.ts:71
msgid "Keep Rounded Corners when Maximized or Fullscreen"
msgstr "إبقاء الزوايا المدورة في وضع التكبير أو ملء الشاشة"

#: src/preferences/widgets/reset_page.ts:70
#: src/preferences/widgets/reset_page.ts:73
msgid "Corner Smoothing"
msgstr "تمليس الزاوية"

#: src/utils/prefs.ts:48
msgid "Expand this row to pick a window."
msgstr "كبر الصف لاختيار نافذة."

#: src/utils/ui.ts:105 src/utils/ui.ts:134
#: src/utils/background_menu.ts:60 src/utils/background_menu.ts:82
msgid "Rounded Corners Settings..."
msgstr "إعدادات الزوايا المدورة..."

#~ msgid "Expand this row to pick a window."
#~ msgstr "كبر الصف لاختيار نافذة."

#~ msgid "Reset Preferences"
#~ msgstr "إعادة ضبط الإعدادات"

Expand Down
39 changes: 19 additions & 20 deletions po/cs.po
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ msgid ""
msgstr ""
"Project-Id-Version: 10\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-07-22 11:54-0700\n"
"POT-Creation-Date: 2024-09-14 21:07+0300\n"
"PO-Revision-Date: 2023-04-25 17:52+0000\n"
"Last-Translator: Fjuro <[email protected]>\n"
"Language-Team: Czech <https://hosted.weblate.org/projects/rounded-window-"
Expand Down Expand Up @@ -142,7 +142,7 @@ msgid "Debug"
msgstr "Ladění"

#: src/preferences/pages/general.ui:174
#: src/preferences/widgets/reset_page.ts:61
#: src/preferences/widgets/reset_page.ts:64
msgid "Enable Log"
msgstr "Povolit protokol"

Expand Down Expand Up @@ -260,17 +260,17 @@ msgstr ""
msgid "_Reset"
msgstr ""

#: src/preferences/widgets/app_row.ts:28
#: src/preferences/widgets/app_row.ts:27
#, fuzzy
msgid "Window class"
msgstr "Stín okna"

#: src/preferences/widgets/app_row.ts:48
#: src/preferences/widgets/app_row.ts:47
#, fuzzy
msgid "Expand this row, to pick a window"
msgstr "Rozbalte tento řádek a vyberte okno."

#: src/preferences/widgets/app_row.ts:92
#: src/preferences/widgets/app_row.ts:86
#, fuzzy
msgid "Can't pick window from this position"
msgstr "Nelze vybrat okno z této pozice"
Expand Down Expand Up @@ -300,54 +300,53 @@ msgstr "Zachovat zaoblené rohy v režimu celé obrazovky"
msgid "Always clip rounded corners even for fullscreen window"
msgstr "Při zobrazení okna na celou obrazovku vždy zachovat zaoblené rohy."

#: src/preferences/widgets/reset_page.ts:54
#: src/preferences/widgets/reset_page.ts:57
msgid "Skip LibAdwaita Applications"
msgstr "Přeskočit aplikace LibAdwaita"

#: src/preferences/widgets/reset_page.ts:56
#: src/preferences/widgets/reset_page.ts:59
msgid "Skip LibHandy Applications"
msgstr "Přeskočit aplikace LibHandy"

#: src/preferences/widgets/reset_page.ts:57
#: src/preferences/widgets/reset_page.ts:60
msgid "Focus Window Shadow Style"
msgstr "Styl stínu zaměřeného okna"

#: src/preferences/widgets/reset_page.ts:58
#: src/preferences/widgets/reset_page.ts:61
msgid "Unfocus Window Shadow Style"
msgstr "Styl stínu nezaměřeného okna"

#: src/preferences/widgets/reset_page.ts:59
#: src/preferences/widgets/reset_page.ts:62
msgid "Border Width"
msgstr "Šířka okraje"

#: src/preferences/widgets/reset_page.ts:60
#: src/preferences/widgets/reset_page.ts:63
msgid "Border Color"
msgstr "Barva okraje"

#: src/preferences/widgets/reset_page.ts:65
#: src/preferences/widgets/reset_page.ts:68
msgid "Border Radius"
msgstr "Poloměr okraje"

#: src/preferences/widgets/reset_page.ts:66
#: src/preferences/widgets/reset_page.ts:69
msgid "Padding"
msgstr "Výplň"

#: src/preferences/widgets/reset_page.ts:68
#: src/preferences/widgets/reset_page.ts:71
msgid "Keep Rounded Corners when Maximized or Fullscreen"
msgstr "Zachovat zaoblené rohy při maximalizaci nebo režimu na celou obrazovku"

#: src/preferences/widgets/reset_page.ts:70
#: src/preferences/widgets/reset_page.ts:73
msgid "Corner Smoothing"
msgstr "Vyhlazování rohů"

#: src/utils/prefs.ts:48
msgid "Expand this row to pick a window."
msgstr "Rozbalte tento řádek a vyberte okno."

#: src/utils/ui.ts:105 src/utils/ui.ts:134
#: src/utils/background_menu.ts:60 src/utils/background_menu.ts:82
msgid "Rounded Corners Settings..."
msgstr "Nastavení zaoblených rohů..."

#~ msgid "Expand this row to pick a window."
#~ msgstr "Rozbalte tento řádek a vyberte okno."

#~ msgid ""
#~ "Setup different clip padding by add window into this list.\n"
#~ "\n"
Expand Down
39 changes: 19 additions & 20 deletions po/de.po
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-07-22 11:54-0700\n"
"POT-Creation-Date: 2024-09-14 21:07+0300\n"
"PO-Revision-Date: 2023-04-18 06:49+0000\n"
"Last-Translator: Jörn Weigend <[email protected]>\n"
"Language-Team: German <https://hosted.weblate.org/projects/rounded-window-"
Expand Down Expand Up @@ -144,7 +144,7 @@ msgid "Debug"
msgstr "Debug"

#: src/preferences/pages/general.ui:174
#: src/preferences/widgets/reset_page.ts:61
#: src/preferences/widgets/reset_page.ts:64
msgid "Enable Log"
msgstr "Logging aktivieren"

Expand Down Expand Up @@ -262,17 +262,17 @@ msgstr ""
msgid "_Reset"
msgstr ""

#: src/preferences/widgets/app_row.ts:28
#: src/preferences/widgets/app_row.ts:27
#, fuzzy
msgid "Window class"
msgstr "Fensterschatten"

#: src/preferences/widgets/app_row.ts:48
#: src/preferences/widgets/app_row.ts:47
#, fuzzy
msgid "Expand this row, to pick a window"
msgstr "Eintrag aufklappen, um ein Fenster auszuwählen."

#: src/preferences/widgets/app_row.ts:92
#: src/preferences/widgets/app_row.ts:86
#, fuzzy
msgid "Can't pick window from this position"
msgstr "Kann kein Fenster von dieser Position auswählen"
Expand Down Expand Up @@ -302,54 +302,53 @@ msgstr "Zeige abgerundete Ecken im Vollbild"
msgid "Always clip rounded corners even for fullscreen window"
msgstr "Abgerundete Ecken für Fenster im Vollbildmodus behalten."

#: src/preferences/widgets/reset_page.ts:54
#: src/preferences/widgets/reset_page.ts:57
msgid "Skip LibAdwaita Applications"
msgstr "LibAdwaita-Anwendungen auslassen"

#: src/preferences/widgets/reset_page.ts:56
#: src/preferences/widgets/reset_page.ts:59
msgid "Skip LibHandy Applications"
msgstr "LibHandy-Anwendungen auslassen"

#: src/preferences/widgets/reset_page.ts:57
#: src/preferences/widgets/reset_page.ts:60
msgid "Focus Window Shadow Style"
msgstr "Schattenstil für fokussierte Fenster"

#: src/preferences/widgets/reset_page.ts:58
#: src/preferences/widgets/reset_page.ts:61
msgid "Unfocus Window Shadow Style"
msgstr "Schattenstil für unfokussierte Fenster"

#: src/preferences/widgets/reset_page.ts:59
#: src/preferences/widgets/reset_page.ts:62
msgid "Border Width"
msgstr "Rahmenbreite"

#: src/preferences/widgets/reset_page.ts:60
#: src/preferences/widgets/reset_page.ts:63
msgid "Border Color"
msgstr "Rahmenfarbe"

#: src/preferences/widgets/reset_page.ts:65
#: src/preferences/widgets/reset_page.ts:68
msgid "Border Radius"
msgstr "Rahmenradius"

#: src/preferences/widgets/reset_page.ts:66
#: src/preferences/widgets/reset_page.ts:69
msgid "Padding"
msgstr "Innenabstand"

#: src/preferences/widgets/reset_page.ts:68
#: src/preferences/widgets/reset_page.ts:71
msgid "Keep Rounded Corners when Maximized or Fullscreen"
msgstr "Zeige abgerundete Ecken im Vollbild oder bei Maximierung"

#: src/preferences/widgets/reset_page.ts:70
#: src/preferences/widgets/reset_page.ts:73
msgid "Corner Smoothing"
msgstr "Kantenglättung"

#: src/utils/prefs.ts:48
msgid "Expand this row to pick a window."
msgstr "Eintrag aufklappen, um ein Fenster auszuwählen."

#: src/utils/ui.ts:105 src/utils/ui.ts:134
#: src/utils/background_menu.ts:60 src/utils/background_menu.ts:82
msgid "Rounded Corners Settings..."
msgstr "Einstellungen für abgerundete Ecken..."

#~ msgid "Expand this row to pick a window."
#~ msgstr "Eintrag aufklappen, um ein Fenster auszuwählen."

#~ msgid ""
#~ "Setup different clip padding by add window into this list.\n"
#~ "\n"
Expand Down
Loading

0 comments on commit 0ace2ff

Please sign in to comment.