Making footnotes compatible with picky CMSes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posterous (and possibly other CMS systems) does not like colons in the "id" or "name" attributes of html elements. Also, it strips out "id" attributes for most elements (including the "li" element of the MMdown footnote). So this commit adds "a name=fn_footnoteid" elements to the footnote "li" elements, as well as changing the footnote name/id to "fn_footnoteid" rather than "fn:footnoteid".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi fletcher,
This is edge case, yes, but here's what's prompted me to patch MMdown. I use Notational Velocity (nvAlt) to write blog posts. I use MMdown w/ footnotes. I view the source and copy/paste it into posterous's html editor, and it takes the liberty of stripping out "id" attributes from the "li" footnote elements, and on top of that, chokes on the colons in the footnote ids.
This patch replaces colons with underscores. It also adds "a name=fn_footnoteid"-style anchors — which posterous accepts — in order to give the footnotes a proper link.
I absolutely love MMdown, thanks for all the hard work.
All best,
Nano