Skip to content

remove removesuffix to support python 3.8 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

th3w1zard1
Copy link

@th3w1zard1 th3w1zard1 commented Aug 10, 2024

I needed a rtf parser for python 3.8 and this was the closest library I could find that met my purposes. Python 3.8 is the last supported python version on windows 7 which unfortunately I need to target.

This library contained a single incompatibility: removesuffix. Like most of 3.9's changes, it can easily be rewritten to support 3.8's functionality.

I have been using this library for over an hour and have not found any other incompatibilities with python 3.8.

if there are any other code segments this PR can backport please let me know.

@fleetingbytes
Copy link
Owner

Thanks for the PR, but I don't feel very compelled to merge it. Python 3.8 will be end-of-lifed in October 2024 (tomorrow). I understand that under Windows 7 you have no other option, but for that case you can use your fork. The other reason I don't want to merge it is that the current code base needs a clean up along the lines of Bob Martin's Clean Code guidelines. I may decide to make it compatible once I'll be refactoring it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants