Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general improvements #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

general improvements #2

wants to merge 3 commits into from

Commits on Jun 27, 2023

  1. refactor: improve scrobbler code 

    - refactor error handling to use `result` types
- use proper string concatenation methods for efficiency
- make API base URL configurable
- update struct names to follow snake_case convention
- add inline comments and documentation for clarity
    @g1-1-1
    g1-1-1 authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b82ae8a View commit details
    Browse the repository at this point in the history

  2. refactor: improve error handling and code organization in listenbrainz 

    - separate token validation and object initialization logic into distinct functions
- replace unwrap and panic with proper error handling using `result` and the `?` operator
- remove unnecessary string formatting in API requests for better performance
- provide more informative error messages for token validation and network errors
    @g1-1-1
    g1-1-1 authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d2e1928 View commit details
    Browse the repository at this point in the history

  3. refactor: improved readability and error handling in mod 

    - extracts common functionality into helper methods
- uses `result` for error handling
- more constants
    @g1-1-1
    g1-1-1 authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    30e4d9f View commit details
    Browse the repository at this point in the history