Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JWT_COOKIE_SAMESITE property to deleted cookie #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Stijn-B
Copy link

@Stijn-B Stijn-B commented Jan 31, 2022

To delete a httponly cookie, the server responds with a cookie of which the expiration is in the past (https://stackoverflow.com/a/20320610/3179285)

In case of cross origin requests it's important that the SameSite attribute is also the same so I added this parameter to delete_cookie.

pphetra added a commit to onehealthtoolkit/ohtk-api that referenced this pull request Aug 29, 2022
@kevinwfhe
Copy link

Any update on this PR?

@Stijn-B
Copy link
Author

Stijn-B commented Dec 10, 2022

@kevinwfhe This library seems abandoned. I have been using my fork successfully but am in the process of migrating away from graphene because its ecosystem in general isn't very active

@kevinwfhe
Copy link

@kevinwfhe This library seems abandoned. I have been using my fork successfully but am in the process of migrating away from graphene because its ecosystem in general isn't very active

Yea, I think graphene-django hasn't been released with a new version for about a year. I guess will just fork this and use it myself for now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants