Add JWT_COOKIE_SAMESITE property to deleted cookie #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pphetra
added a commit
to onehealthtoolkit/ohtk-api
that referenced
this pull request
Aug 29, 2022
|
Any update on this PR? |
|
@kevinwfhe This library seems abandoned. I have been using my fork successfully but am in the process of migrating away from graphene because its ecosystem in general isn't very active |
Yea, I think graphene-django hasn't been released with a new version for about a year. I guess will just fork this and use it myself for now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To delete a httponly cookie, the server responds with a cookie of which the expiration is in the past (https://stackoverflow.com/a/20320610/3179285)
In case of cross origin requests it's important that the SameSite attribute is also the same so I added this parameter to delete_cookie.