Use context passed via the commandline when discovering cluster version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I was on vacation. Thanks for your fix |
|
I've just tagged v0.4.5 which will feature this fix |
|
Hope you had a great vacation! Thanks Flavio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
kuberlrdisregards the context provided via the command line (--contextflag) and instead always uses thecurrent-contextspecified in the merged kubeconfig.It is very likely that the
current-contextspecified in the kubeconfig will differ from the context specified on the command line — otherwise, the user would have no need to utilize the--contextflag! By defaulting to thecurrent-contextin these scenarios,kuberlrconnects to the wrong cluster when determining the cluster version. The end result is that the wrong version of kubectl may be used to run the users commands.This pull request introduces the necessary code changes to parse the command line arguments and ensure that the specified context is honoured when determining the cluster version.
Thanks for creating
kuberlr!