input-capture: hookup ZonesChanged signal #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable but I'd like to get @whot to take a look. Could you also add a test for the signal? I'll happily help out if there are any questions or problems. |
whot
suggested changes
Jan 29, 2025
3l0w
force-pushed
the
main
branch
2 times, most recently
from
8537504 to
e49a997
Compare
|
Ive corrected code style & rebased from main |
GeorgesStavracas
requested changes
Jan 30, 2025
|
@swick ive added one test, feel free to review it |
GeorgesStavracas
approved these changes
Jan 30, 2025
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a reason that i ignore, this signal was never passed from the xdg-desktop-portal impl to the application