githooks: Replace pre-commit tool with simple shell script #1581
+65
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes mypy happy.
instead of the entire string which can contain other data, such as the bus name. Also adds an assert to ensure template is actually of type string which makes mypy happy.
It's basically impossible to run mypy with pre-commit because it will ignore the repo config and check all files changed the commit. The dbusmock templates are special and mypy fails on them so we use the mypy config to skip them. This introduces a new script which checks the python tests and installs all the required tools into a python virtual environment. It also changes to pre-commit hook to call the script if any of the files in tests changed and uses git stash push/pop to get the test a clean state of the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets is mypy in addition to ruff check and ruff format. I spent way too many hours trying to make things work with pre-commit and I don't think it's even possible. CI runs the check script directly, the git-hooks integration only when a commit changes something in tests.