pytest: Isolate directories, start permission store and add umockdev support #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @whot |
Merged
swick
force-pushed
the
wip/pytest-improvements-part2
branch
from
6bedc64 to
97bb235
Compare
whot
approved these changes
Oct 24, 2024
swick
force-pushed
the
wip/pytest-improvements-part2
branch
from
97bb235 to
701f80f
Compare
|
Depends on #1486 now. It also adds a workaround to keep ASAN working while using LD_PRELOAD. |
swick
force-pushed
the
wip/pytest-improvements-part2
branch
2 times, most recently
from
316bb2b to
4ff06c8
Compare
|
Needs rebase. The leak commits could also be its own PR. |
If PortalMock was subclassing DBusTestCase, then TearDown would be called, but it's not. Yield the PortalMock and call tear_down afterwards. This also reveals a bug where the loop iterated over the keys instead of the values.
This ensure that we don't use or modify any data from the actual system and instead have a clean, predictable environment for tests without the risk of accidentally modifying something on the host.
This way it becomes reusable when we want to start more components.
We now isolate the test environment so that the permission store will start with an empty state but.
This makes sure that the portal frontend exited cleanly. This includes no memory leaks detected by ASAN and for that to work we need our suppression file.
We re-exec the test case in pytest_configure if the LD_PRELOAD doesn't contain libumockdev-preload.so. Even if the system doesn't have it, it will show up in the environment and we can continue. It also sets the UMOCKDEV_DIR env for the portal frontend. In theory dbusmock should already do this for us but it doesn't seem to be working. Finally, it makes sure that ASAN keeps working even when LD_PRELOAD is being used which is always the case because we require umockdev.
swick
force-pushed
the
wip/pytest-improvements-part2
branch
from
4ff06c8 to
41d06b8
Compare
|
Rebased. Created a new PR for the memory leak fixes #1491. This PR still depends on them because it requires ASAN to pass for the tests to pass. |
TingPing
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1451
What the title says. This is prep work for being able to test the USB portal with the python harness.