Uniformize application as app #1327
Conversation
|
Was asked to ack, LGTM 👍 |
| @@ -751,7 +751,7 @@ handle_request_background_in_thread_func (GTask *task, | |||
| subtitle = g_strdup_printf (_("%s requests to be started automatically and run in the background."), info ? g_app_info_get_display_name (info) : id); | |||
| else | |||
| subtitle = g_strdup_printf (_("%s requests to run in the background."), info ? g_app_info_get_display_name (info) : id); | |||
| body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the application settings.")); | |||
| body = g_strdup (_("The ‘run in background’ permission can be changed at any time from the app settings.")); | |||
There was a problem hiding this comment.
is this referring to the settings for the app, or to Applications settings found in Settings apps?
There was a problem hiding this comment.
Application settings found in Settings app. But what about other DEs on this and "app" name?
There was a problem hiding this comment.
If this is the case, then it would be good to have this be "applications settings" since it would be referring to general settings.
There was a problem hiding this comment.
Is this worse than what is it right now? Should we just go ahead and merge this?
At the end of the day, this is generic code shared by all environments so being more specific seems out of the question.
There was a problem hiding this comment.
Just "application settings" is still confusing in my opinion. However, that’s less a problem if all DEs give the background permission automatically like in GNOME.
Uniformize occurrences of "application"(s) and "app"(s) as the latter.
Occurrences of application(s):
src/background.c, line 754
The ‘run in background’ permission can be changed at any time from the application settings.
src/location.c, line 566
An application wants to use your location.
src/screenshot.c, line 265
Allow Applications to Take Screenshots?
src/screenshot.c, line 266
An application wants to be able to take screenshots at any time.
src/wallpaper.c, lines 215 and 216
Allow Applications to Set Backgrounds?
An application is requesting to be able to change the background image.
Occurrences of app(s):
src/device.c, line 122 and 123, 137 and 138
Allow app to Use the Microphone?
An app wants to access recording devices.
Allow app to Use the Speakers?
An app wants to access audio devices.
src/device.c, lines 152 and 153
Allow app to Use the Camera?
An app wants to access camera devices.
src/dynamic-launcher.c, lines 131 and 719
Desktop file id missing app id prefix '%s.': %s
RequestInstallToken() not allowed for app id %s