Update rubygems and add a devcontainer #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #506 |
razzeee
commented
Jan 23, 2022
| gem "middleman", "~> 3"#, github: "middleman/middleman", branch: "v3-stable" | ||
| gem "middleman-matomo", github: "barthalion/middleman-matomo" | ||
| gem "middleman", "~> 4"#, github: "middleman/middleman", branch: "v3-stable" | ||
| gem 'matomo-middleman' |
There was a problem hiding this comment.
This seems to work fine, as far as I can tell without deploying it. Locally everything seems to be added correctly.
But I'm not sure what the changes in @barthalion fork were
There was a problem hiding this comment.
I don't actually remember at this point.
There was a problem hiding this comment.
Guess we figured out why :D
razzeee
commented
Jan 23, 2022
| @@ -16,14 +16,14 @@ gem "sass" #3.2.12 | |||
| # gem "middleman-syntax" | |||
|
|
|||
| #deployment | |||
| gem "middleman-deploy" #, "~> 2.0.0.pre.alpha" | |||
| gem "middleman-deploy", "~> 2.0.0.pre.alpha" | |||
There was a problem hiding this comment.
Based on karlfreeman/middleman-deploy#132 (comment) doesn't work without for me
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all gems, so that it can build again with the current versions of ruby and rubygem.
It also adds a devcontainer, so that people can run it without installing anything ruby on their system.