-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Freedesktop SDK based image #173
Open
tytan652
wants to merge
7
commits into
flatpak:master
Choose a base branch
from
tytan652:freedesktop_based_image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a44fccc
Add Freedesktop SDK based image
tytan652 3ae000a
CI: Add Freedesktop SDK based image workflows
tytan652 b781b63
Add Flatpak remotes to the base image
tytan652 96e3cbf
Add flatpak-builder-linter the base image
tytan652 2e5cae9
Add GitHub CLI the base image
tytan652 bffd288
Add aarch64 support to the base image
tytan652 a9b99bb
Add update-binfmts action
tytan652 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
kind: autotools | ||
|
||
build-depends: | ||
- freedesktop-sdk.bst:public-stacks/buildsystem-autotools.bst | ||
|
||
depends: | ||
- freedesktop-sdk.bst:components/libpipeline.bst | ||
|
||
variables: | ||
conf-local: >- | ||
--disable-upstart | ||
|
||
sources: | ||
- kind: tar | ||
url: https://download.savannah.nongnu.org/releases/binfmt-support/binfmt-support-2.2.2.tar.gz | ||
ref: cce14163f9b526283e6f0d00f3be1cfe239fa2c7574e5e0ba8ad3db74166a4a5 |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I want to steal this too now 😆 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
kind: manual | ||
|
||
build-depends: | ||
- freedesktop-sdk.bst:components/util-linux.bst | ||
|
||
config: | ||
configure-commands: | ||
- | | ||
sed -i 's|${qemu_target_list}|"aarch64"|g' src/scripts/qemu-binfmt-conf.sh | ||
|
||
install-commands: | ||
- | | ||
install -Dm755 -t "%{install-root}%{bindir}" qemu-aarch64 | ||
- | | ||
mkdir -p %{install-root}%{datadir}/binfmts | ||
src/scripts/qemu-binfmt-conf.sh --debian --exportdir "%{install-root}%{datadir}/binfmts" --qemu-path "%{bindir}" --persistent yes --preserve-argv0 yes | ||
|
||
strip-commands: | ||
- true | ||
|
||
sources: | ||
- kind: tar | ||
base-dir: '' | ||
url: | ||
github_files:tonistiigi/binfmt/releases/download/deploy%2Fv8.0.4-33/qemu_v8.0.4_linux-amd64.tar.gz | ||
ref: 924cd873807a87d800ea914a7d4b1d81973e935839e9596cf4ff7183290b4572 | ||
- kind: tar | ||
directory: src | ||
url: qemu:qemu-8.0.4.tar.xz | ||
ref: 81c817dda38af958be5bef1a6cf55b658bb2d3fb87c1e6a571de6b7b2c44516c |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could avoid needing binfmt-support by adding a config in
/etc/binfmt.d
systemd should already be providing the binfmt service and it probably will work in the container too.https://www.man7.org/linux/man-pages/man5/binfmt.d.5.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Systemd services is a no-go/op in Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And binfmt requires privileged access