fix: incorporate the review from @Totto16

flatpak · Feb 5, 2025 · f93378a · f93378a
1 parent dda2056
commit f93378a
Show file tree

Hide file tree

Showing 5 changed files with 284 additions and 444 deletions.
diff --git a/flatpak-builder/dist/index.js.LICENSE.txt b/flatpak-builder/dist/index.js.LICENSE.txt
diff --git a/flatpak-builder/index.js b/flatpak-builder/index.js
@@ -391,11 +391,11 @@ const run = async (config) => {
         return
       }
 
-      const artifact = new DefaultArtifactClient()
+      const artifactClient = new DefaultArtifactClient()
       core.info('Uploading artifact...')
       // Append the arch to the bundle name to prevent conflicts in multi-arch jobs
       const bundleName = config.bundle.replace('.flatpak', '') + `-${config.arch}`
-      return artifact.uploadArtifact(bundleName, [config.bundle], '.', {
+      return artifactClient.uploadArtifact(bundleName, [config.bundle], '.', {
         continueOnError: false
       })
     })

diff --git a/flatpak-builder/package.json b/flatpak-builder/package.json
@@ -3,8 +3,7 @@
   "main": "index.js",
   "license": "MIT",
   "scripts": {
-    "test": "jest",
-    "build": "webpack --progress --config webpack.prod.js"
+    "test": "jest"
   },
   "jest": {
     "verbose": true,
@@ -21,11 +20,11 @@
     "js-yaml": "^4.1.0"
   },
   "devDependencies": {
-    "eslint": "^9.19.0",
+    "eslint": "^8.49.0",
     "eslint-config-standard": "^17.1.0",
-    "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-jest": "^28.11.0",
-    "eslint-plugin-n": "^17.15.1",
+    "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-jest": "^27.2.1",
+    "eslint-plugin-n": "^16.0.2",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^7.2.1",
     "jest": "^29.7.0",

diff --git a/flatpak-builder/webpack.prod.js b/flatpak-builder/webpack.prod.js