Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: Create CACHEDIR.TAG file in state dir #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vanadiae
Copy link
Contributor

This makes it possible for backup software to detect and ignore the whole folder.

Fixes #360

@hfiguiere
Copy link
Contributor

this sounds like a go idea.

@lctrr
Copy link

lctrr commented Feb 13, 2025

Great idea !

Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, sorry it was missed so long. Just needs rebased.

@lctrr
Copy link

lctrr commented Feb 14, 2025

Thank you very much ! for the rebase do you think the author is still active on GitHub though ?
@Vanadiae

@TingPing
Copy link
Member

No idea, i can find time to rebase it if needed.

This makes it possible for backup software to detect and ignore the
whole folder.

Fixes flatpak#360
@Vanadiae Vanadiae force-pushed the cachedir-tag branch 4 times, most recently from d9cb739 to 4cefc4b Compare February 16, 2025 18:12
@Vanadiae
Copy link
Contributor Author

I tried rebasing on the main branch, however for some reason the CI fails either with (CI logs):

Submodule 'debugedit' (https://sourceware.org/git/debugedit.git) registered for path 'subprojects/debugedit'
  Submodule 'libglnx' (https://gitlab.gnome.org/GNOME/libglnx.git) registered for path 'subprojects/libglnx'
  Cloning into '/home/runner/work/flatpak-builder/flatpak-builder/subprojects/debugedit'...
  Cloning into '/home/runner/work/flatpak-builder/flatpak-builder/subprojects/libglnx'...
  Error: error: Server does not allow request for unadvertised object ae27211cbbfb63a0ad3c141cd1310d7f583ec40e
  Error: fatal: Fetched in submodule path 'subprojects/debugedit', but it did not contain ae27211cbbfb63a0ad3c141cd1310d7f583ec40e. Direct fetching of that commit failed.
  Error: The process '/usr/bin/git' failed with exit code 128

or if I try scrapping my repo then clone again from upstream main branch, apply the patch and update the submodules (as this branch may have gotten too old by this point for some reason?) it now fails with (CI logs):

 echo '#include "config.h"' > libglnx-config.h
make  all-recursive
make[1]: Entering directory '/home/runner/work/flatpak-builder/flatpak-builder'
Making all in data
make[2]: Entering directory '/home/runner/work/flatpak-builder/flatpak-builder/data'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/runner/work/flatpak-builder/flatpak-builder/data'
Making all in .
make[2]: Entering directory '/home/runner/work/flatpak-builder/flatpak-builder'
make[2]: *** No rule to make target 'subprojects/debugedit/tools/md5.c', needed by 'subprojects/debugedit/tools/flatpak_builder_debugedit-md5.o'.  Stop.
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/runner/work/flatpak-builder/flatpak-builder'
make[1]: *** [Makefile:2510: all-recursive] Error 1
make[1]: Leaving directory '/home/runner/work/flatpak-builder/flatpak-builder'
make: *** [Makefile:1172: all] Error 2

Interestingly it seems like the other two CI build jobs that use meson instead of the autoconf build work just fine as the meson job installs the debugedit directly with apt-get, contrary to the autotools build. I'm not familiar with these CI stuff however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider marking the cache folder as a cache folder
5 participants