Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibilities in test_sbx for python <3.11 #1314

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

ethanbb
Copy link
Contributor

@ethanbb ethanbb commented Mar 29, 2024

Description

Fixes build error in #1311

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Has your PR been tested?

caimanmanager test passes on 3.11 - if any invalid syntax for <3.11 remains, should be caught in CI

@ethanbb
Copy link
Contributor Author

ethanbb commented Mar 29, 2024

Well looks like the nice type annotation syntax doesn't work on 3.9... updating now

@pgunn
Copy link
Member

pgunn commented Mar 29, 2024

At least stuff like this reminds us that python is getting better! I think there were just some upstream packaging issues that currently block us from switching over (tensorflow and one other thing, I think); when we do I'm looking forward to going through the codebase and modernising the syntax (my favourite kind of diff to work on)

@ethanbb ethanbb changed the title Fix invalid indexing in sbx_utils for python <3.11 Fix incompatibilities in test_sbx for python <3.11 Mar 29, 2024
@pgunn pgunn merged commit a93098d into flatironinstitute:dev Mar 29, 2024
3 checks passed
@pgunn
Copy link
Member

pgunn commented Mar 29, 2024

Thanks! I'll be cutting a new release shortly (today or tomorrow); mostly a bugfix for the thing you found earlier that I thought was already out, but your sbx fix here will also be part of it; you won't need to use a compiled build for very long (unless you want to).

@ethanbb
Copy link
Contributor Author

ethanbb commented Mar 29, 2024

Great, thank you for being so responsive and helping me get this out!

@kushalkolar
Copy link
Collaborator

I'm think this is py3.10+ https://peps.python.org/pep-0604/

according to NEP 29 python3.9 support stops in numpy on April 5 so it's not too far out, but tensorflow usually lags behind quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants