-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime, rework dependencies #161
Conversation
Started test build 167424 |
Build 167424 successful
|
Started test build 167427 |
Build 167427 successful
|
Thanks for the pull request! Winetricks recommends 7zip over p7zip starting with the following commit: Going by that, updating it should be OK. p7zip specifically should not be required by anything else. |
Started test build 169077 |
Build 169077 failed |
Started test build 169078 |
Build 169078 successful
|
Fix #164 |
Started test build 169084 |
Should the flatpak then be updated to use upstream winetricks? Currently the build uses your fork. However, the symlink to z7a should achieve compatibility in any case. The latest upstream version of winetricks works for me, but I get a ton of warnings about 64-bit prefixes. |
Build 169084 successful
|
The fork has a few minor patches to make it work more nicely with Proton and the Flatpak sandbox (disabling the continuous 64-bit prefix warnings is one of the patches). They can be found here: https://github.com/Matoking/winetricks/commits/snapshot-2023-08-16-pt I'll look into updating the fork, as it seems a bit overdue. |
Started test build 169477 |
Build 169477 successful
|
Started test build 169493 |
Build 169493 successful
|
Is your fork being used for anything other than flatpak? If not, we could change the flatpak build to the latest upstream release (which is also almost a year old) and patch in your commits.
I tried to fix upstream issue 2183 but could not find an easy way. Maybe it is possible to remove the arch detection and hardcode it in? But that is probably beyond the scope of this PR. I have also switched to using unrar-free (as suggested by winetricks) and the symlinks to unrar and 7za should solve possible compatibility issues. |
Maintaining the fork as a separate repository instead of separate patch files was done mostly for being more convenient. There's also the possibility of having Protontricks download a patched copy of Winetricks automatically and use that, but that would involve plenty of work and possibly introduce confusion with the system Winetricks, so I haven't pursued it. Anyway, aside from the |
Winetricks uses the `7z` executable.
Started test build 171414 |
Build 171414 successful
|
I've merged the pull request after adding a Thanks for the pull request! |
Update runtime to 24.08.
Remove python3-setuptools-scm and perl as they are part of the runtime.
Replace p7zip with build from p7zip-project, since development is now happening there. This follows several other flathub manifests. Question: Should it perhaps be replaced with upstream 7zip?
Update components and add x-checker data for some.