Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug causing "Unknown speaker!" in ami recipe #977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alkazap
Copy link

@alkazap alkazap commented Jul 1, 2021

Original Issue: #976

closes #[976]

Summary

python prepare.py fails with AssertionError: Unknown speaker! FEE005

Test Plan (required)

Assertion error comes from utils.py line 117 assert speaker in speakers, f"Unknown speaker! {speaker}"

Judging by the assertion and line 119 speaker = speakers[speaker], the script expects speakers to be a dictionary, however, as we can see on line 111 speakers = {(speaker.id, speaker) for speaker in speakers}, speakers is a set of tuples.

Line 111 should be speakers = { speaker.id : speaker for speaker in speakers }, then the script works as intended.

Judging by assertion (line 115) and speaker access (line 117) statements, I think on line 111 the intention was to create a dictionary from the list of speakers {speaker.id: speaker for speaker in speakers}, but instead a set of tuples {(speaker.id, speaker) for speaker in speakers} was created, causing assert speaker in speakers to fail. I fixed it accordingly.
@facebook-github-bot
Copy link

Hi @alkazap!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants