feat: add reproducible debian packaging with goreleaser & CI workflow #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoeMahhouk
force-pushed
the
main
branch
9 times, most recently
from
672b6f8 to
2e06404
Compare
metachris
reviewed
Jun 19, 2025
metachris
reviewed
Jun 19, 2025
metachris
reviewed
Jun 19, 2025
metachris
reviewed
Jun 19, 2025
metachris
reviewed
Jun 19, 2025
| set -e | ||
|
|
||
| if ! id "go-template" &>/dev/null; then | ||
| useradd --system --no-create-home --shell /bin/false go-template |
There was a problem hiding this comment.
i don't think on installation it should create users and modify the overall system by default 🤔
There was a problem hiding this comment.
This is following the packaging best practices of having the binary, systemd, and the user creation which the systemd will use to execute the binary with. So part of the deb installation process.
We could remove this but it might be beneficial for the general use-case where you package your workflow and provide a installation/startup process for it
MoeMahhouk
force-pushed
the
main
branch
2 times, most recently
from
d4d29df to
df3c7bd
Compare
metachris
reviewed
Jun 19, 2025
| @@ -64,7 +64,7 @@ jobs: | |||
| run: go install mvdan.cc/[email protected] | |||
|
|
|||
| - name: Install staticcheck | |||
| run: go install honnef.co/go/tools/cmd/staticcheck@2025.1.1 | |||
| run: go install honnef.co/go/tools/cmd/staticcheck@v0.6.1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive updates to the release workflow, packaging system, and reproducibility features for the project. Key changes include enhancements to the GitHub Actions workflow for releases, a new
Makefilesection for packaging, reproducible Debian packaging with GoReleaser, and systemd integration for the HTTP server. These changes aim to improve automation, ensure reproducible builds, and simplify deployment.GitHub Actions Workflow Enhancements
.github/workflows/release.yaml.Packaging and Reproducibility
.goreleaser.yaml.Makefiletargets for building, testing, and cleaning packages, as well as verifying reproducibility of builds.Systemd Integration
packaging/go-template-httpserver.service) for the HTTP server, with configuration for secure operation and logging.packaging/go-template-httpserver.default) for customizable runtime parameters.Post-Install and Cleanup Scripts
Documentation Updates
README.mdwith instructions for reproducible Debian packaging, including prerequisites, build steps, and package contents.