-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm_resources_manager] use cache instead of a plain client #514
base: main
Are you sure you want to change the base?
Conversation
dcb838d
to
8cca014
Compare
Signed-off-by: Mikhail Scherba <[email protected]>
b9bce8d
to
f646dd5
Compare
}, nil | ||
} | ||
|
||
func (hm *helmResourcesManager) WithCache(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not used anywhere. Why do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I forgot to delete it after merging WithKubeClient and WithCache into NewHelmResourcesManager
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
951d930
to
cd6573f
Compare
Overview
Currently, helm resources manager creates a resources monitor for every enabled module that has a helm release. In its turn, a resource monitor periodically checks whether all the resource of the corresponding helm release are presented in the cluster. These checks are performed by retrieving partial metadata for every object of the release via List operation. The main gist of the PR is to get objects' metadata not from the cluster API directly, but rather from the cache, decreasing amount of List operations and speeding up some of the operations related to helm releases (checking if a helm release should be applied, running periodic checks for absent resources).
What this PR does / why we need it
heritage=addon-operator
by default, yet configurable) to every resource the operator deploys (see helm post-renderer functionality).Special notes for your reviewer