feat: load modules from multiple paths, support symlink as module #362
Conversation
- Resolve symlinks in modules directory, use symlink name to determine module name and order - Support multiple paths to search for modules. - Support directories without number prefix as module dirs. Default order is 1. - Remove '3 digits prefix' restriction. - Load values.yaml from all paths. Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
| **GLOBAL_HOOKS_DIR** — a directory with global hook files. | ||
|
|
||
| **ADDON_OPERATOR_NAMESPACE** — a required parameter with namespace where Addon-operator is deployed. | ||
| **MODULES_DIR** — paths separated by colon where modules are located. |
There was a problem hiding this comment.
I also thought about MODULES_PATH
There was a problem hiding this comment.
This rename is a huge thing, it'll require changes in manifests, I don't want to make it in this PR.
RUNNING.md
Outdated
| **ADDON_OPERATOR_NAMESPACE** — a required parameter with namespace where Addon-operator is deployed. | ||
| **MODULES_DIR** — paths separated by colon where modules are located. | ||
|
|
||
| **UNNUMBERED_MODULE_ORDER** — a default order for modules without numbered prefix. |
| } | ||
|
|
||
| if name != "values.yaml" { | ||
| log.Warnf("Ignore '%s' while searching for modules", absPath) |
There was a problem hiding this comment.
This function is going to return empty string, denoting this is not a directory. So this entry will be ignored. Why would we want this warning?
There was a problem hiding this comment.
Those warnings and errors are cheap substitutions for dry-run/lint mode and ignore file :(
pkg/module_manager/module_manager.go
Outdated
| } | ||
| log.Errorf("Possible bug!!! GetModule: no module '%s' in ModuleManager indexes", name) |
There was a problem hiding this comment.
It's not a bug, just no such module. It is fine, CALM DOWN AND DON'T PANIC!!!
deckhouse-controller module values my-inexisting-module
There was a problem hiding this comment.
Good point, yeah. The caller should check for nil.
There was a problem hiding this comment.
it's more about the exclamation ""Possible bug!!!" :)
Co-authored-by: Eugene Shevchenko <[email protected]>
…explain data type for UNNUMBERED_MODULE_ORDER Signed-off-by: Ivan Mikheykin <[email protected]>
Overview
What this PR does / why we need it
Related issues:
Special notes for your reviewer
Does this PR introduce a user-facing change?