make sure all hooks have a hook controller set (#455)

Signed-off-by: Mikhail Scherba <[email protected]>

pkg/module_manager/models/modules/basic.go

@@ -101,6 +101,16 @@ func (bm *BasicModule) DeregisterHooks() {
 	bm.hooks.clean()
 }
 
+// HooksControllersReady returns controllersReady status of the hook storage
+func (bm *BasicModule) HooksControllersReady() bool {
+	return bm.hooks.controllersReady
+}
+
+// SetHooksControllersReady sets controllersReady status of the hook storage to true
+func (bm *BasicModule) SetHooksControllersReady() {
+	bm.hooks.controllersReady = true
+}
+
 // ResetState drops the module state
 func (bm *BasicModule) ResetState() {
 	bm.state = &moduleState{

pkg/module_manager/models/modules/hook_storage.go

@@ -10,10 +10,11 @@ import (
 
 // HooksStorage keep module hooks in order
 type HooksStorage struct {
-	registered bool
-	lock       sync.RWMutex
-	byBinding  map[sh_op_types.BindingType][]*hooks.ModuleHook
-	byName     map[string]*hooks.ModuleHook
+	registered       bool
+	controllersReady bool
+	lock             sync.RWMutex
+	byBinding        map[sh_op_types.BindingType][]*hooks.ModuleHook
+	byName           map[string]*hooks.ModuleHook
 }
 
 func newHooksStorage() *HooksStorage {

pkg/module_manager/module_manager.go

@@ -966,6 +966,11 @@ func (mm *ModuleManager) LoopByBinding(binding BindingType, fn func(gh *hooks.Gl
 
 	for _, moduleName := range mm.enabledModules.GetAll() {
 		m := mm.GetModule(moduleName)
+		// skip module if its hooks don't have hook controllers set
+		if !m.HooksControllersReady() {
+			continue
+		}
+
 		moduleHooks := m.GetHooks(binding)
 		for _, mh := range moduleHooks {
 			fn(nil, m, mh)

pkg/module_manager/module_manager_hooks.go

@@ -142,6 +142,9 @@ func (mm *ModuleManager) RegisterModuleHooks(ml *modules.BasicModule, logLabels
 			})
 	}
 
+	// set controllersReady to true
+	ml.SetHooksControllersReady()
+
 	return nil
 }