MatchItem supports on all resource selector fields #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/improve-resource-selectors
branch
from
71dc297 to
824a3ca
Compare
adityathebe
force-pushed
the
feat/improve-resource-selectors
branch
from
43a9396 to
28721e2
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
adityathebe
force-pushed
the
feat/improve-resource-selectors
branch
2 times, most recently
from
48b68ad to
dd4b5c5
Compare
moshloop
reviewed
Jan 27, 2025
adityathebe
force-pushed
the
feat/improve-resource-selectors
branch
from
b0aa7cc to
845f152
Compare
adityathebe
commented
Jan 28, 2025
| }) | ||
| }) | ||
|
|
||
| var _ = ginkgo.Describe("Search Properties", ginkgo.Ordered, ginkgo.Pending, func() { |
adityathebe
commented
Jan 28, 2025
| Configs: []types.ResourceSelector{{Namespace: "missioncontrol", Types: []string{*dummy.LogisticsDBRDS.Type}}}, | ||
| }, | ||
| Configs: []models.ConfigItem{dummy.LogisticsDBRDS}, | ||
| }, | ||
| // TODO: Currently search does not support labels/tags |
This is so that we get prefix/suffix support
field selector only selects fields
adityathebe
force-pushed
the
feat/improve-resource-selectors
branch
from
845f152 to
e4a9816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1285