Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle null notification summary values #1062

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

yashmehrotra
Copy link
Member

failed to lookup property NotificationGroup: no such overload: _+_

CEL returning errors as columns are null type

              results.rows.map(r, {
                'name': r.namespace + '/' + r.name,
                'icon': 'bell',
                'type': 'Notification',
                'health': r.failed == 0 ? 'healthy' : (r.sent > 0 ? 'warning' : 'unhealthy'),
                'properties':[
                  {'name': 'Sent', 'value': r.sent, 'headline': true},
                  {'name': 'Failed', 'value': r.failed, 'headline': true},
                ],
              }).toJSON()

@moshloop moshloop enabled auto-merge (rebase) September 17, 2024 08:51
@moshloop moshloop merged commit 26d338d into main Sep 17, 2024
6 checks passed
@moshloop moshloop deleted the notif-summary branch September 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants