Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification silence #1030

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat: notification silence #1030

merged 2 commits into from
Sep 10, 2024

Conversation

adityathebe
Copy link
Member

No description provided.

@adityathebe adityathebe marked this pull request as draft September 9, 2024 06:40
type = uuid
default = sql("generate_ulid()")
}
column "namespace" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a namespace column for all our CRDs?

@adityathebe adityathebe force-pushed the feat/notification-silence branch 3 times, most recently from f35e5ba to 81e039c Compare September 9, 2024 17:38
@adityathebe adityathebe marked this pull request as ready for review September 9, 2024 17:38
@adityathebe adityathebe requested a review from moshloop September 9, 2024 17:39
@adityathebe adityathebe force-pushed the feat/notification-silence branch from 81e039c to f7b7473 Compare September 10, 2024 05:45
@moshloop moshloop merged commit 6f6bc24 into main Sep 10, 2024
7 checks passed
@moshloop moshloop deleted the feat/notification-silence branch September 10, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants