fix: write catalog landing page from a customer pov #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for canarychecker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for flanksource-docs failed.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+148
to
+152
| | Field | Description | Scheme | Required | | ||
| | ------------------ | ------------------------------------------------------------------------------------------ | --------------------------------------- | -------- | | ||
| | `name` | The label with the name of the relative | `string` | Yes | | ||
| | `namespace` | The label with the namespace of the relative | `string` | Yes | | ||
| | `kind` | The resource type of the relative | `string` | Yes | |
There was a problem hiding this comment.
The Relationships table appears incomplete. The example YAML shows both expr and value fields being used, but these aren't documented in the table. Also, the table marks all fields as required (Yes), while the main table shows relationships as optional. These inconsistencies should be resolved to match the actual implementation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.