Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llvm_ir_correct tests on Windows #1396

Closed

Conversation

tdusnoki
Copy link
Contributor

On Windows some tests are unable to open iso_fortran_env.mod unless we include it explicitly.

related issue: #1363

On Windows some tests are unable to open iso_fortran_env.mod unless we include it explicitly.
Copy link
Collaborator

@bryanpkc bryanpkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%flags is for specifying custom options, and typically undefined. You need to find another way to solve this problem. Why can't the compiler locate iso_fortran_env.mod? It should be in the include/ directory of the Classic Flang installation, which should be one of the standard include paths.

@kaadam
Copy link
Collaborator

kaadam commented Jul 13, 2023

%flags is for specifying custom options, and typically undefined. You need to find another way to solve this problem. Why can't the compiler locate iso_fortran_env.mod? It should be in the include/ directory of the Classic Flang installation, which should be one of the standard include paths.

Yes, you're right. The 'AddFlangSystemIncludeArgs' implementation is missed from MSVC toolchain, please see: flang-compiler/classic-flang-llvm-project#161

@tdusnoki
Copy link
Contributor Author

After testing with flang-compiler/classic-flang-llvm-project/pull/161 this PR is no longer necessary, thanks for the feedback.

@tdusnoki tdusnoki closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants