Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The array dimensions must be defined *before* being used #1391

Merged

Conversation

dmikushin
Copy link
Contributor

It's a pity that for someone the order of arguments takes precedence over this obvious requirement

@bryanpkc
Copy link
Collaborator

Thanks for fixing the problem. The original code happens to work correctly thanks to implicit typing, but the corrected form looks better and will silence warnings from compilers that enforce newer language standards.

Could you please follow LLVM conventions and add a topic prefix (e.g. "[flang1]", "[runtime]", etc.) to the commit title?

Also, would you mind removing your commentary from commit messages? This code probably predated the Fortran 2008 standard, when the rules for declaration order in specification expressions were made explicit. There is no need to insult the original author of the code.

@dmikushin dmikushin force-pushed the define-array-dimensions-before-use branch from 8e8b448 to e95aca0 Compare June 28, 2023 20:28
@dmikushin dmikushin force-pushed the define-array-dimensions-before-use branch from e95aca0 to 0089a38 Compare June 28, 2023 20:32
@dmikushin
Copy link
Contributor Author

dmikushin commented Jun 28, 2023

This and my other comments express how deeply saddened I am by the poor state of this project. We deal now with the result of years of destructive management and attempts to raise as much money as possible with the least effort. Perhaps you are not aware that a single license of this "product" was once sold at a price of $900.

And even now that we have the opportunity to bring this legacy nightmare into good quality state, it is being run by companies that use it as a spoiler in their hardware sales, develop their closed-source branches, and are not interested in developing anything other than their own successful deals.

I would like to see the releases of this project as a vendor-independent product. Releases should be easily accessible, and users should be well informed of their availability. By supporting this effort you will get a lot of respect from the community, and there will be a lot less criticism in all aspects.

@bryanpkc
Copy link
Collaborator

LLVM Flang is much better designed from the get-go, and most developers have already moved on to it, so unfortunately this "legacy nightmare" isn't going to get any more corporate attention than it is getting today.

We are doing our best in upstreaming useful features and important fixes, and we are well aware of the huge amount of technical debt we inherited, but our first priority is stability. A lot of the known issues require massive refactoring to fix, and we cannot justify the time investment or the potential risk to stability.

We discussed community releases a long time ago, but we could not find any interest or volunteers, so we decided not to provide any.

@bryanpkc bryanpkc requested a review from pawosm-arm June 28, 2023 22:13
@pawosm-arm pawosm-arm merged commit 7cc1996 into flang-compiler:master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants