Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the functions signatures to match the expected function pointer signatures #1390

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Adjust the functions signatures to match the expected function pointer signatures #1390

merged 1 commit into from
Jul 25, 2023

Conversation

dmikushin
Copy link
Contributor

No description provided.

@dmikushin
Copy link
Contributor Author 

D:/a/flang/flang/tools/flang1/flang1exe/semsym.c(625,35): error: omitting the parameter name in a function definition is a C2x extension [-Werror,-Wc2x-extensions]
set_internref_stfunc(int ast, int*)

Oh I see, I must give it a dummy name.

@dmikushin dmikushin force-pushed the fixing-functions-signatures branch from 24122cb to 685608a Compare June 28, 2023 13:22
@dmikushin
Copy link
Contributor Author

@pawosm-arm , could you please re-deploy the CI, thanks.

@pawosm-arm
Copy link
Collaborator

@pawosm-arm , could you please re-deploy the CI, thanks.

Seems it happened without my intervention

bryanpkc
bryanpkc approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@bryanpkc bryanpkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanpkc bryanpkc merged commit 36c17ea into flang-compiler:master Jul 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanpkc bryanpkc bryanpkc approved these changes

@pawosm-arm pawosm-arm pawosm-arm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmikushin @pawosm-arm @bryanpkc