win: Fix upperilm header generation #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranchandramohan
requested review from
kiranchandramohan,
bryanpkc and
isuruf
|
It was needed to add a list filter since after the upperilm.in is preprocessed following lines appear in the output. We should ignore all of them. |
29 tasks
bryanpkc
reviewed
Dec 16, 2021
clang-cl doesn't recognize "-P -E -x c" compiler arguments, we should use MSVC version of them "/E /TC". Seems clang-cl is not able to handle /P /E together so I only left the necessary one. Due to preprocessing upperilm.in, '#' will be represented in output. It needs to add a new list filter which exclude those lines which starts with '#'. Fixes: flang-compiler#1192
isuruf
approved these changes
Dec 21, 2021
|
This Windows PR has received the required number of approvals. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-cl doesn't recognize "-P -E -x c" compiler arguments,
we should use MSVC version of them "/E /TC".
Seems clang-cl is not able to handle /P /E together
so I only left the necessery one.
Fixes: #1192