Skip to content

win: Enable Windows port in CMakefiles #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

win: Enable Windows port in CMakefiles #1184

merged 1 commit into from
Jan 17, 2022

Conversation

kaadam
Copy link
Collaborator

@kaadam kaadam commented Nov 30, 2021 •
edited
Loading

Fixes: #1154

@kaadam kaadam added the windows Add this to all windows specific issues or PRs label Nov 30, 2021
@kaadam kaadam mentioned this pull request Dec 15, 2021
Closed
@kaadam kaadam mentioned this pull request Jan 11, 2022
Closed
29 tasks
isuruf
isuruf approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a rebase.

kiranchandramohan
kiranchandramohan approved these changes Jan 16, 2022
View reviewed changes
Copy link
Collaborator

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase and one of us will merge.

@kaadam
win: Fix the build on Windows on ARM
c176768 
* Avoid to build x86_64 intrinsics for ARM.
* Use general Windows macro instead of x86_64 specific.
@kaadam
Copy link
Collaborator Author

kaadam commented Jan 17, 2022 •
edited
Loading

@kiranchandramohan @isuruf Done, Thanks.

@kiranchandramohan kiranchandramohan merged commit c2816c4 into flang-compiler:master Jan 17, 2022
@kaadam
Copy link
Collaborator Author

kaadam commented Jan 17, 2022

@kiranchandramohan Unfortunately I made a mistake during the rebase. I amended the cmake PR into the previous build fix commit which has already been merged. Shall I create a revert for that to clean up the commits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranchandramohan kiranchandramohan kiranchandramohan approved these changes

@isuruf isuruf isuruf approved these changes

@bryanpkc bryanpkc Awaiting requested review from bryanpkc

@shivaramaarao shivaramaarao Awaiting requested review from shivaramaarao

@xoviat xoviat Awaiting requested review from xoviat

Assignees
No one assigned
Labels
windows Add this to all windows specific issues or PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable building Flang for Windows (experimental)
3 participants
@kaadam @kiranchandramohan @isuruf