feat: don't make unnecessary requests to get buckets #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoalmeidaee
force-pushed
the
feature/no-unnecessary-bucket-access
branch
from
7f80e35 to
3e0d5f9
Compare
CloudStorage's `check_bucket` implementation would (as the name implies) check that the bucket exists. This, however, requires a `storage.buckets.get` permission that seems to be only found by default in legacy roles. This commit refactors so that calls to CloudStorage that don't set `auto_create_bucket` will skip the bucket check altogether
rodrigoalmeidaee
force-pushed
the
feature/no-unnecessary-bucket-access
branch
4 times, most recently
from
330c843 to
bafdf8e
Compare
iasmini
approved these changes
Feb 11, 2025
rodrigoalmeidaee
force-pushed
the
feature/no-unnecessary-bucket-access
branch
from
fa5c4dc to
6c4022b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudStorage's
check_bucketimplementation would (as the name implies) check that the bucket exists. This, however, requires astorage.buckets.getpermission that seems to be only found by default in legacy roles.This commit refactors so that calls to CloudStorage that don't set
auto_create_bucketwill skip the bucket check altogether