Give pins a different window title #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for a KDE issue where the capture window can't be differentiated from the pin window in any way, making the multi-monitor workaround in flameshot-org#3073 also break pins.
|
Especially for wayland where flameshot doesn't really work optimally this is a small and elegant solution. Personally I'd remove any spaces in the title since it somehow always breaks with different escaping characters, other than that; LGTM |
|
Any update on this? This is a pretty major issue for me, I use pins a good bit, and it's a huge pain in the rear having them stuck in the upper right, not to mention that multiple pins don't work at all. Worth noting that it's a single-line fix, too. |
|
@typecasto thanks for the PR. This is indeed useful especially for tiling window managers. I agree that the space may cause some issue soe some window managers. Would you please remove the space? Otherwise it looks good to me too. |
Flameshot Pin => flameshot-pin
|
@mmahmoudian Done |
mmahmoudian
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for a KDE issue where the capture window can't be differentiated from the pin window in any way, making the multi-monitor workaround in #3073 also break pins.