Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Windows support more obvious #344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stefnotch
Copy link

I read the flamegraph-rs readme, and couldn't quite tell if Windows is supported. This edits the Readme to make it more obvious.

Though, with this edit, it no longer pushes users to try out dtrace on Windows. Is that good or bad?

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably mention both the dtrace and the blondie backends, and ideally make a recommendation which of the two is more useful/reliable.

@stefnotch
Copy link
Author

Okay, I reworked the Readme a bit more, let me know what you think. I tried to imitate the readmes of other popular projects, like this one.

Regarding the backends, is blondie the more reliable one? That was my best guess after reading the issue tracker. If yes, then I'll add the recommendation.

@djc
Copy link
Contributor

djc commented Nov 10, 2024

Sorry, it's a little hard to review these changes since it's a whole bunch of stuff mashed together. Would prefer small commits that make one logical change at a time, which makes it easier to review, so I can verify the changes against the motivation.

@stefnotch
Copy link
Author

Okay, I'll rewrite the git history and let you know once I'm done. I was hoping that it's short enough to review in one go, but I suppose having a more granular changeset is helpful.

@djc
Copy link
Contributor

djc commented Nov 10, 2024

Thanks -- sorry, I don't have a ton of time to devote to flamegraph so trying to make this efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants