Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed file permission of lib/robots.rb, addressing issue #6. #10

Closed
wants to merge 1 commit into from

Conversation

Romulus10
Copy link

Changed the file permissions for lib/robots.rb from 644 to 755. This might not be ideal, but for now it patches issue #6.

@busterb
Copy link

busterb commented Aug 28, 2017

I'm not sure if that will fix it. The issue is that the file isn't readable by all when the gem is installed, it doesn't need to be executable: https://github.com/rapid7/metasploit-omnibus/blob/master/config/software/metasploit-framework.rb#L73

I think this might be due to an overly-restrictive umask being set when the gem was last built (or maybe it was a buggy version of the gem command).

@Romulus10
Copy link
Author

I see what you're saying. The read permissions are present now in the repository version, but now that I'm looking again it might not carry over when installed via gem.

@Romulus10
Copy link
Author

Sorry, had a moment there - that's exactly what it was before. Well I thought I had an idea...

@Romulus10 Romulus10 closed this Aug 28, 2017
@busterb
Copy link

busterb commented Aug 28, 2017

This whole gem is just one file though, and hasn't been updated in 7 years. I imagine we could probably just embed a copy and not miss out on much.

@Romulus10
Copy link
Author

Agreed. It might be relatively painless depending on how many places we need to change where we're looking for robots.rb

@busterb
Copy link

busterb commented Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants