feature/remove-age #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
approved these changes
Dec 9, 2024
Co-authored-by: Joe Markiewicz <[email protected]>
CHANGELOG.md
Outdated
|
|
||
| ## Breaking Changes | ||
| - In the [July 2023 TikTok Ads connector update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`. | ||
| - Previously, we coalesced these two columns in the `stg_tiktok_ads__ad_group_history` model to account for connectors using the old naming convention. However, due to inconsistent data types, we can no longer use this approach. |
There was a problem hiding this comment.
Should we include the specific data types (strings and jsons right)?
There was a problem hiding this comment.
Good call. Updated!
DECISIONLOG.md
Outdated
| ### Action for Customers Requiring Historical `age` Data | ||
| Customers who still need the historical `age` column data can: | ||
| 1. Resync the `ADGROUP_HISTORY` table in their TikTok Ads connector. TikTok provides all historical data in the `age_groups` column, allowing the data to be fully populated. |
There was a problem hiding this comment.
Is there supposed to be a second option? If not, we should prob remove the 1.
There was a problem hiding this comment.
oops removed.
Co-authored-by: Jamie Rodriguez <[email protected]>
There was a problem hiding this comment.
@fivetran-jamie Thanks for reviewing! I updated with your suggestions.
CHANGELOG.md
Outdated
|
|
||
| ## Breaking Changes | ||
| - In the [July 2023 TikTok Ads connector update](https://fivetran.com/docs/connectors/applications/tiktok-ads/changelog#july2023) for the `ADGROUP_HISTORY` table, the `age` column was renamed to `age_groups`. | ||
| - Previously, we coalesced these two columns in the `stg_tiktok_ads__ad_group_history` model to account for connectors using the old naming convention. However, due to inconsistent data types, we can no longer use this approach. |
There was a problem hiding this comment.
Good call. Updated!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
age_groupsandagecoalesce in adgroup_history staging model #25This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present) && dbt testBefore marking this PR as "ready for review" the following have been applied:
Detailed validation steps have been provided belowDetailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃